[MDL-68402] get_with_capability_join OR logic is wrong when two capabilities are passed and one is overridden with a prevent (affects Quiz reports) - Moodle Tracker

XML

Word

Printable

Testing Instructions:

Hide

There should be no visible change. The automated tests will regression-test this.

Please run the accesslib unit tests with PHPUNIT_LONGTEST set to 1.

Show
There should be no visible change. The automated tests will regression-test this. Please run the accesslib unit tests with PHPUNIT_LONGTEST set to 1.
Affected Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE
Fixed Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE
Pull from Repository:
https://github.com/timhunt/moodle.git
Pull 3.8 Branch:
~~MDL-68402~~_38
Pull 3.8 Diff URL:
https://github.com/timhunt/moodle/compare/MOODLE_38_STABLE...MDL-68402_38
Pull Master Branch:
~~MDL-68402~~
Pull Master Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-68402

The place this can make a difference is in the quiz reports: steps to reproduce:

Go to the quiz report for a quiz (e.g. https://qa.moodledemo.net/mod/quiz/report.php?id=30&mode=overview)
Note that some students are shown
In another tab, open the Permissions setting for that quiz (e.g. https://qa.moodledemo.net/admin/roles/permissions.php?contextid=9063)
Remove one of the mod/quiz:reviewmyattempts or mod/quiz:attempt capabilities, but not both.
Reload the quiz report.

Expected result: the students are not shown.
Actual result: 'No students enrolled in this course yet' message.

Participants:: Amaia Anabitarte, CiBoT, Jun Pataleta, Sam Marshall, Tim Hunt, ToBiC

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)

Estimated:

Not Specified

Remaining:

Logged:

3h 30m