[MDL-68438] Changing notification email format fails if messaging is disabled - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.7.5, 3.8.2, 3.9.2, 3.10
Fix Version/s: 3.8.6, 3.9.3
Component/s: Messages
Labels:
- release_notes
- triaged

Affected Branches:
MOODLE_310_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_38_STABLE, MOODLE_39_STABLE
Pull from Repository:
https://github.com/t-schroeder/moodle
Pull 3.9 Branch:
~~MDL-68438~~_39
Pull 3.9 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_39_STABLE...t-schroeder:MDL-68438_39
Pull Master Branch:
~~MDL-68438~~_master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...t-schroeder:MDL-68438_master
Testing Instructions:
Hide

As admin disable messaging via Site administration -> Messaging -> Messaging settings -> Enable messaging system: No

Go to Notification menu (bell icon in the top right) -> Notification preferences (gear icon).

Click on "Email" (or the gear icon next to it).

In the modal that opens change the Email format.

Click "Save changes".

Confirm you see no error or popups and your preference is changed successfully.
Show
As admin disable messaging via Site administration -> Messaging -> Messaging settings -> Enable messaging system: No Go to Notification menu (bell icon in the top right) -> Notification preferences (gear icon). Click on "Email" (or the gear icon next to it). In the modal that opens change the Email format. Click "Save changes". Confirm you see no error or popups and your preference is changed successfully.

Description

When messaging is disabled for the site you can't change the email format for notifications. When you try to do you get en error modal. This is where the check happens:

https://github.com/moodle/moodle/blob/788dfb9c7dad27824ee524de5c1cb9e43b31b98a/message/externallib.php#L4125-L4128

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-68438.png
95 kB
22/Oct/20 2:54 PM
notification-preferences-email-format-error-messaging-disabled.png
35 kB
17/Apr/20 3:28 AM

Activity

People

Assignee:: Tim Schroeder

Reporter:: Tim Schroeder

Peer reviewer:: Simey Lameze

Integrator:: Jake Dallimore

Tester:: Anna Carissa Sadia

Participants:: Anna Carissa Sadia, CiBoT, Jake Dallimore, Simey Lameze, Tim Schroeder

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 17/Apr/20 3:24 AM

Updated:: 04/Nov/20 3:09 PM

Resolved:: 23/Oct/20 9:07 PM

Fix Release Date:: 9/Nov/20

Time Tracking

Estimated:

Remaining:

Logged:

2h 30m