Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68438

Changing notification email format fails if messaging is disabled

    XMLWordPrintable

Details

    • MOODLE_310_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • MOODLE_38_STABLE, MOODLE_39_STABLE
    • MDL-68438_master
    • Hide
      1. As admin disable messaging via Site administration -> Messaging -> Messaging settings -> Enable messaging system: No
      2. Go to Notification menu (bell icon in the top right) -> Notification preferences (gear icon).
      3. Click on "Email" (or the gear icon next to it).
      4. In the modal that opens change the Email format.
      5. Click "Save changes".
      6. Confirm you see no error or popups and your preference is changed successfully.
      Show
      As admin disable messaging via Site administration -> Messaging -> Messaging settings -> Enable messaging system: No Go to Notification menu (bell icon in the top right) -> Notification preferences (gear icon). Click on "Email" (or the gear icon next to it). In the modal that opens change the Email format. Click "Save changes". Confirm you see no error or popups and your preference is changed successfully.

    Description

      When messaging is disabled for the site you can't change the email format for notifications.  When you try to do you get en error modal. This is where the check happens:

      https://github.com/moodle/moodle/blob/788dfb9c7dad27824ee524de5c1cb9e43b31b98a/message/externallib.php#L4125-L4128

      Attachments

        Activity

          People

            tschroeder Tim Schroeder
            tschroeder Tim Schroeder
            Simey Lameze Simey Lameze
            Jake Dallimore Jake Dallimore
            Anna Carissa Sadia Anna Carissa Sadia
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              9/Nov/20

              Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 30 minutes
                2h 30m