Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Blocker
-
Resolution: Fixed
-
Affects Version/s: 3.9
-
Fix Version/s: 3.9
-
Component/s: Libraries, Web Services
-
Testing Instructions:
-
Affected Branches:MOODLE_39_STABLE
-
Fixed Branches:MOODLE_39_STABLE
-
Epic Link:
-
Pull from Repository:
-
Pull Master Branch:
MDL-68454-master -
Pull Master Diff URL:
Description
So I was trying to use the new "dynamic" async table_sql in my own project MDL-67748.
Regardless all the other points mentioned elsewhere related to violating the current naming guidelines for external functions (which I am going to ignore here), I spent a while trying to understand what I need to to make use of this new mechanism.
At the end of the day (almost literally), I found that it cannot actually work because the current implementation of core_table\external\dynamic::execute() has hard-coded usage of core_user\table\participants_filterset():
So it cannot be used with my own table and my own filterset. I am not sure if this is forgotten relic of a development or what. Also, I can't at the moment imagine what is your plan on how the filterset will be instantiated here.