Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68463

"Show all [count]" link not updated on search

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.9
    • Fix Version/s: 3.9
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide
      1. Enter a course with at least 50 users shown
      2. Navigate to the Participants page
      3. Note the number of users found at the top
        1. Confirm that the number of users matches in the "[x] participants found", "Show all [x]", and "Select all [x] users" strings
      4. Press the "Select all [x] users" button
        1. Confirm that the page did not reload
        2. Confirm that the table content updated to show all usere
        3. Confirm that the checkbox at the start of each row was selected
        4. *Confirm that the "Show all [x]" text now says "Show 20 per page"
        5. *Confirm that the "Select all [x] users" is no longer visible
      5. From the initials bar filter the users to only show a subset of them
        1. Confirm that the number of users at the top ("[x] participants founds") has changed to reflect the results
      6. From the initials bar choose the "All" options again
      7. Toggle between the "Show 20 per page" and "Show all [x]" views
        1. Confirm that the page did not reload
        2. Confirm that the table content updated to show all usere
        3. Confirm that the checkbox at the start of each row was not selected
        4. *Confirm that the "Show all [x]" text switches back and forth between "Show 20 per page"
        5. Confirm that the "Select all [x] users" is visible when there are only 20 users on the page
      Show
      Enter a course with at least 50 users shown Navigate to the Participants page Note the number of users found at the top Confirm that the number of users matches in the " [x] participants found", "Show all [x] ", and "Select all [x] users" strings Press the "Select all [x] users" button Confirm that the page did not reload Confirm that the table content updated to show all usere Confirm that the checkbox at the start of each row was selected *Confirm that the "Show all [x] " text now says "Show 20 per page" *Confirm that the "Select all [x] users" is no longer visible From the initials bar filter the users to only show a subset of them Confirm that the number of users at the top (" [x] participants founds") has changed to reflect the results From the initials bar choose the "All" options again Toggle between the "Show 20 per page" and "Show all [x] " views Confirm that the page did not reload Confirm that the table content updated to show all usere Confirm that the checkbox at the start of each row was not selected *Confirm that the "Show all [x] " text switches back and forth between "Show 20 per page" Confirm that the "Select all [x] users" is visible when there are only 20 users on the page
    • Affected Branches:
      MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_39_STABLE
    • Pull Master Branch:
      MDL-68463-master-3
    • Story Points:
      2

      Description

      When a query is applied we do not update the "Show all [count]" link.

      We should not update the "Number of participants" count because this is worded as being the total number of participants in the course.

      BUT we may which to change it to something more useful, like:

      Showing 120 of 3000 participants
      

      That is, to show the total number of people in the course (3000) and the number that are shown in the filter (120).

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Michael Hawkins
              Integrator:
              Jun Pataleta
              Tester:
              Gladys Basiana
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Jun/20

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 days, 6 hours, 9 minutes
                  2d 6h 9m