Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68476

Undefined indexes during bulk editting of feedback activity completion

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Make sure that completion tracking is set to yes for the course.
      2. Create a feedback activity.
      3. Create a lesson activity.
      4. Go to "Edit course completion settings"
      5. Select tab "Bulk edit activity completion"
      6. Check the "activities/resources" completion tracking
      7. Click on the edit button
        • Select "Show activity as complete when conditions are met" in the drop down
        • Check "Student must view this activity to complete it"
        • Save your changes
      Expected result:

      Changes are stored

      Actual result:

      × Notice: Undefined index: page_after_submit in mod/feedback/mod_form.php on line 146
      × Notice: Undefined index: page_after_submitformat in mod/feedback/mod_form.php on line 148
      × Changes saved
      × Changes saved
      × This page should automatically redirect. If nothing is happening please use the continue link below.

      Show
      Make sure that completion tracking is set to yes for the course. Create a feedback activity. Create a lesson activity. Go to "Edit course completion settings" Select tab "Bulk edit activity completion" Check the "activities/resources" completion tracking Click on the edit button Select "Show activity as complete when conditions are met" in the drop down Check "Student must view this activity to complete it" Save your changes Expected result: Changes are stored Actual result: × Notice: Undefined index: page_after_submit in mod/feedback/mod_form.php on line 146 × Notice: Undefined index: page_after_submitformat in mod/feedback/mod_form.php on line 148 × Changes saved × Changes saved × This page should automatically redirect. If nothing is happening please use the continue link below.
    • Affected Branches:
      MOODLE_38_STABLE

      Description

      When you use bulk edit the activity completion of a feedback, 2 notices are shown per feedback, disabling auto redirect:

      Notice: Undefined index: page_after_submit in mod/feedback/mod_form.php on line 146
      Notice: Undefined index: page_after_submitformat in mod/feedback/mod_form.php on line 148
      This page should automatically redirect. If nothing is happening please use the continue link below.

        Attachments

          Activity

            People

            Assignee:
            Unassigned
            Reporter:
            rdebleu Renaat Debleu
            Participants:
            Component watchers:
            Sam Marshall, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated: