Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68529

Activity chooser has to fetch data before showing

XMLWordPrintable

    • MOODLE_39_STABLE
    • MOODLE_39_STABLE
    • Hide

      Setup

      • 1 site with this patch applied
      • 1 course

      Test:

      1. Navigate to your course
      2. Turn editing on
      3. Simulate a slow connection so the fix can be easily verified:
        1. Open your browser's developer tools.
        2. Go to the network tab.
        3. Throttle the connection speed (e.g. on Chrome, set the Throttling option to "Slow 3G".
      4. Under any section select "Add an activity or resource"
      5. Confirm That a modal shows with a loading icon
      6. Confirm That after some amount of time that the icon is replaced with the activity chooser content
      Show
      Setup 1 site with this patch applied 1 course Test: Navigate to your course Turn editing on Simulate a slow connection so the fix can be easily verified: Open your browser's developer tools. Go to the network tab. Throttle the connection speed (e.g. on Chrome, set the Throttling option to " Slow 3G ". Under any section select "Add an activity or resource" Confirm That a modal shows with a loading icon Confirm That after some amount of time that the icon is replaced with the activity chooser content
    • 3
    • Moodlenet massive mop-up 2

      When you initially click to open the activity chooser nothing happens at first. The page must wait to perform an initial fetch of the module data before it even indicates that anything is happening.

      It should instead show the dialogue immediately, as soon as the button is clicked, but show that it is loading.

      One a slow connection this can take over half a second at the moment.

        1. MDL-68529.mp4
          632 kB

            mathewmay Mathew May
            dobedobedoh Andrew Lyons
            Mihail Geshoski Mihail Geshoski
            Jun Pataleta Jun Pataleta
            Anna Carissa Sadia Anna Carissa Sadia
            Votes:
            2 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 3 hours, 10 minutes
                1d 3h 10m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.