[MDL-68556] Plugins check page styling during the upgrade - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.9
Fix Version/s: 3.7.6, 3.8.3
Component/s: Administration, Themes
Labels:
- ci
- triaged
- ui_change

Affected Branches:
MOODLE_39_STABLE
Fixed Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE
Pull from Repository:
git://github.com/mudrd8mz/moodle.git
Pull Master Branch:
~~MDL-68556~~-master-pluginscheckcss
Pull Master Diff URL:
https://github.com/mudrd8mz/moodle/compare/f570a79071...MDL-68556-master-pluginscheckcss
Testing Instructions:
Hide

Test in Boost and Clean and with a RTL language, too.

Make sure that your Moodle files directory is writeable by the web server.

Log in as admin.

Go to Site administration > Plugins > Install plugins

Upload the attached [^test_68556.zip] as a plugin ZIP

Click "Install plugin from the ZIP file" button

Go through the installation / upgrade wizard up to the "Plugins check" page

You should see a section "Available missing dependencies" with the "Level up! - Gamification" plugin and the "Plugins requiring attention" with the "Level enrolment" plugin being installed.

TEST - Make a visual check that the page layout is sane and not apparently broken.
Show
Test in Boost and Clean and with a RTL language, too. Make sure that your Moodle files directory is writeable by the web server. Log in as admin. Go to Site administration > Plugins > Install plugins Upload the attached [^test_68556.zip] as a plugin ZIP Click "Install plugin from the ZIP file" button Go through the installation / upgrade wizard up to the "Plugins check" page You should see a section "Available missing dependencies" with the "Level up! - Gamification" plugin and the "Plugins requiring attention" with the "Level enrolment" plugin being installed. TEST - Make a visual check that the page layout is sane and not apparently broken.

Description

Similarly to ~~MDL-68393~~, the upgrade from bootstrap 2 to bootstrap 4 based themes left the default plugins check page without the custom styles. As seen on the screenshot, it is mostly about missing margins between elements that make it harder to orient at the screen.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

68556.png
117 kB
06/May/20 3:07 PM
enrol_xp_moodle38_2018051800.zip
30 kB
29/Apr/20 9:06 PM
MDL-68556_Boost.jpg
43 kB
07/May/20 4:17 PM
MDL-68556_Classic.jpg
41 kB
07/May/20 4:17 PM
screenshot-1.png
115 kB
29/Apr/20 5:52 PM
test_68553.zip
32 kB
07/May/20 9:17 AM

Issue Links

Testing discovered

MDL-68558 Admin can get stuck on the Plugin dependencies check failure page

Closed

MDL-68622 Striped tables colour contrast

Closed

Activity

People

Assignee:: David Mudrák (@mudrd8mz)

Reporter:: David Mudrák (@mudrd8mz)

Peer reviewer:: Luca Bösch

Integrator:: Andrew Lyons

Tester:: Anna Carissa Sadia

Participants:: Andrew Lyons, Anna Carissa Sadia, Bas Brands, CiBoT, David Mudrák (@mudrd8mz), Luca Bösch

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Huong Nguyen, Bas Brands, Mathew May, Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 29/Apr/20 5:49 PM

Updated:: 08/May/20 8:02 PM

Resolved:: 08/May/20 8:02 PM

Fix Release Date:: 11/May/20

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

3h 55m