Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68569

static method customfield_select\field_controller::get_options_array()

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Run automated tests (similar to MDL-66135)

      1. Init phpunit, then run vendor/bin/phpunit --testsuite core_customfield_testsuite,customfield_select_testsuite
        1. Verify it ends without errors.
      2. Init behat, then run admin/tool/behat/cli/run.php --name="An admin can update courses using a CSV file"
        1. Verify it ends without errors.
      3. Init behat, then run admin/tool/behat/cli/run.php --name="An admin can create courses using a CSV file"
        1. Verify it ends without errors.
      Show
      Run automated tests (similar to MDL-66135 ) Init phpunit, then run vendor/bin/phpunit --testsuite core_customfield_testsuite,customfield_select_testsuite Verify it ends without errors. Init behat, then run admin/tool/behat/cli/run.php --name="An admin can update courses using a CSV file" Verify it ends without errors. Init behat, then run admin/tool/behat/cli/run.php --name="An admin can create courses using a CSV file" Verify it ends without errors.
    • Affected Branches:
      MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE
    • Pull 3.10 Branch:
      MDL-68569-310
    • Pull Master Branch:

      Description

      From MDL-66135:

      ... but it called the attention like crazy to me, is there any reason for \ customfield_select\field_controller::get_options_array() to be static? It's the only static stuff within custom fields and, unless I'm wrong, all its uses are from instantiated places.

      This is about to consider if there is any reason for it to be static and proceed to make it a normal instance method instead.

      Ciao

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              pholden Paul Holden
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Peer reviewer:
              Peter Dias
              Integrator:
              Andrew Nicols
              Tester:
              Anna Carissa Sadia
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Nov/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 57 minutes
                  3h 57m