Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68571

Upgrade from 3.5 -> 3.9(master) fails on upgradesettings page

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.9
    • Fix Version/s: 3.9
    • Component/s: H5P
    • Testing Instructions:
      Hide

      NOTE

      All tests must be executed on Moodle 3.5, 3.6, 3.7 and 3.8.

      Test scenario: Upgrade the Moodle instance to master.

      1. Create a new Moodle instance (no master).
      2. Login as an admin.
      3. Go to the Dashboard and add new Block HTML.
      4. Upgrade the new Moodle instance to master.
      5. Expected Result: Confirm that the installation has been successfully and with NO errors.
      6. Expected Result: Confirm you could see the new settings to set once the upgrade has finished and you can see the H5P settings (H5P framework handler wit this value H5P framework v1.24 (h5plib_v124) as default).
      7. Go to the Dashboard and click on Customise this page button.
      8. Go to the Block HTML adding before and configure the new HTML Block.
      9. Expected Result: Confirm that you can see the block settings with no errors.
      10. Add a the H5P file attached to this issue (chart.h5p) into the content setting using the Atto button named H5P. Click on Save changes once you had added the H5P file.
      11. Expected Result: Confirm you can upload the H5P file with no errors and you can see this nice chart.
      12. Go to H5P setting in  Site administration / H5P / H5P settings
      13. Expected Result: Confirm you can see the H5P framework handler  dropdown with this value: H5P framework v1.24 (h5plib_v124
      Show
      NOTE All tests must be executed on Moodle 3.5, 3.6, 3.7 and 3.8. Test scenario: Upgrade the Moodle instance to master. Create a new Moodle instance (no master). Login as an admin. Go to the Dashboard and add new Block HTML. Upgrade the new Moodle instance to master. Expected Result: Confirm that the installation has been successfully and with NO errors. Expected Result: Confirm you could see the new settings to set once the upgrade has finished and you can see the H5P settings (H5P framework handler wit this value H5P framework v1.24 (h5plib_v124) as default). Go to the Dashboard and click on Customise this page button. Go to the Block HTML adding before and configure the new HTML Block. Expected Result: Confirm that you can see the block settings with no errors. Add a the H5P file attached to this issue (chart.h5p) into the content setting using the Atto button named H5P. Click on Save changes once you had added the H5P file. Expected Result: Confirm you can upload the H5P file with no errors and you can see this nice chart. Go to H5P setting in  Site administration / H5P / H5P settings Expected Result: Confirm you can see the H5P framework handler  dropdown with this value:  H5P framework v1.24 (h5plib_v124 ) 
    • Affected Branches:
      MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_39_STABLE
    • Pull Master Branch:
      MDL-68571-master

      Description

      when upgrading to 3.9, the upgradesettings page generates a fatal error with the following:

      Invalid JS url, it has to be shortened url starting with / or moodle_url instance.
      due to:

      line 83 of /lib/editor/atto/plugins/h5p/lib.php: call to page_requirements_manager->js()

      This appears to be caused because the atto plugin upgrade settings are running before the h5plibraryhandler core setting has a value.

      If I visit:
      admin/settings.php?section=h5psettings

      and manually save this page, the upgrade settings page then loads and allows the upgrade to complete.

        Attachments

        1. chart.h5p
          107 kB
        2. h5psettings.png
          h5psettings.png
          28 kB
        3. MDL-68571.jpg
          MDL-68571.jpg
          60 kB
        4. MDL-68571 (2).jpg
          MDL-68571 (2).jpg
          36 kB
        5. Screenshot 2020-05-06 at 18.47.24.png
          Screenshot 2020-05-06 at 18.47.24.png
          30 kB

          Activity

            People

            Assignee:
            cescobedo Carlos Escobedo
            Reporter:
            danmarsden Dan Marsden
            Peer reviewer:
            Mihail Geshoski
            Integrator:
            Sara Arjona (@sarjona)
            Tester:
            Anna Carissa Sadia
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              15/Jun/20

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 7 hours, 25 minutes
                7h 25m