Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68592

Inline layout is broken for form group containing nested group

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      There is no form in the core that would contain nested group. Please use attached test file for layout testing.

      1. Put formtest.php into the root of your Moodle codebase.
      2. Open it in the browser.
      3. Check that layout issue is fixed, so "Username", "equal" and the first empty text field are displayed in the same row (as defined in the description).
      4. Verify that any existing group layout is not broken. For instance, navigate to admin/user/user_bulk.php page (it contains 5 different groups of elements).
      5. Make sure the layout is not broken.
      Show
      There is no form in the core that would contain nested group. Please use attached test file for layout testing. Put formtest.php into the root of your Moodle codebase. Open it in the browser. Check that layout issue is fixed, so "Username", "equal" and the first empty text field are displayed in the same row (as defined in the description). Verify that any existing group layout is not broken. For instance, navigate to admin/user/user_bulk.php page (it contains 5 different groups of elements). Make sure  the layout is not broken.
    • Affected Branches:
      MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull Master Branch:
      MDL-68592-master

      Description

      While this is not affecting any interface in core, it is a possible scenario of group use.

      Say, if form group contains another group within it, the layout currently looks like:

      The patch is addressing the issue, making the layout look like:

        Attachments

        1. afterfix.png
          afterfix.png
          11 kB
        2. formtest.php
          2 kB
        3. nofix.png
          nofix.png
          11 kB

          Activity

            People

            Assignee:
            kabalin Ruslan Kabalin
            Reporter:
            kabalin Ruslan Kabalin
            Peer reviewer:
            Marina Glancy
            Integrator:
            Sara Arjona (@sarjona)
            Tester:
            Simey Lameze
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              13/Jul/20

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 hours, 53 minutes
                4h 53m