Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68606

Moodlenet profile validation should return a promise (and object).

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: 3.8.3, 3.9
    • Fix Version/s: None
    • Component/s: Other
    • Story Points:
      1
    • Sprint:
      Moodlenet massive mop-up 2

      Description

      The validation of a user's moodlenet profile encounters an error if the basic checks fail. This is due to the expectation that the return is a promise.

      admin/tool/moodlenet/amd/src/validator.js line 37 should be update to return a promise of an object:

      {result: false, message: 'did not work'} // replace with my hard coded message with a string. 

       

      1. Please update the docblock accordingly.
      2. Must be changed on the 3.7 / 3.8 plugin as well.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              mathewmay Mathew May
              Reporter:
              abgreeve Adrian Greeve
              Peer reviewer:
              Peter Dias
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 40 minutes
                  2h 40m