Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68667

Use 'shorttitle' parameter on the 'select_file' filepicker function

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Prerequisites:

      Test:

      1. As an admin go to a course and add a new 'Page'
      2. Add a value for the required 'Title' field
      3. In the 'Page content' field, click on the 'Insert or edit an audio/video file' atto button.
      4. Click on 'Browse repositories...' button
      5. Select 'YouTube videos' repository
      6. Search for 'Moodle' videos
      7. Select 'What is Moodle?' video
      8. Confirm you see 'Select What is Moodle?' and that there's no '.avi' extension on the title
      9. Click on 'Select this file'
      10. Click on 'Insert media'
      11. 'Save and display'
      12. Confirm there's no error and you can watch the video

       

       

      Show
      Prerequisites: Get a developer API key setup for access to youtube (see  https://developers.google.com/youtube/v3/getting-started  or https://docs.moodle.org/38/en/YouTube_videos_repository ). Basically, go to  https://console.developers.google.com Setup a project Under "APIs and Auth" > Apis, select "YouTube Data API" and enable the api. Under "APIs and Auth" > Credentials, create a new Public API access key. This is the key you will give to Moodle. Go to Site administration > Plugins > Repositories > Manage repositories and mark 'YouTube videos' repository as 'Enabled and visible' Add your API key and Save. Test: As an admin go to a course and add a new 'Page' Add a value for the required 'Title' field In the 'Page content' field, click on the 'Insert or edit an audio/video file' atto button. Click on 'Browse repositories...' button Select 'YouTube videos' repository Search for 'Moodle' videos Select 'What is Moodle?' video Confirm you see 'Select What is Moodle?' and that there's no '.avi' extension on the title Click on 'Select this file' Click on 'Insert media' 'Save and display' Confirm there's no error and you can watch the video    
    • Affected Branches:
      MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE
    • Pull from Repository:
    • Pull 3.8 Branch:
    • Pull Master Branch:
      MDL-68667-master
    • Sprint:
      Moppies Kanban

      Description

      Whatever the 'shorttitle' is empty or not, select_file function is always using the 'title' parameter value. 

      When 'shortitle' is passed as parameter it should be used as the displayname instead of the 'title'.

      So the 'Select XXX' should use the displayname, and not always the 'title' value.

        Attachments

          Activity

            People

            Assignee:
            amaia Amaia Anabitarte
            Reporter:
            amaia Amaia Anabitarte
            Peer reviewer:
            Ferran Recio
            Integrator:
            Sara Arjona (@sarjona)
            Tester:
            Janelle Barcega
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              13/Jul/20

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 3 hours, 15 minutes
                1d 3h 15m