-
Improvement
-
Resolution: Fixed
-
Minor
-
Future Dev
-
MOODLE_401_STABLE
-
MDL-68668-extra-redis-debugging -
Follow up from MDL-67075 with hindsight, in production we will want a reasonably high acquire lock threshold so we do not lose data, but at the same time we want to emit warnings if the lock does take longer than a smaller threshold to be gain, but isn't so bad that it actually fails. This is to inform where to target further dev work to reduce lock contention.
1) Add in the timestamp of when the lock was acquired
2) Allow a shorter warning threshold so we could do say debug at 10 seconds, but keep waiting for another 110 = 120 total
This could reuse $CFG->debugsessionlock if set or have it's own config.php level setting
3) Also when we warn ask redis for the current locks TTL and add that to debug message