Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68675

Duplicate identifiers returned by mod_forum\privacy\provider::export_all_posts_in_discussion()

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Minor
    • None
    • 3.8.3
    • Forum
    • MOODLE_38_STABLE

    Description

      The method mod_forum\privacy\provider::export_all_posts_in_discussion()) uses get_records_sql() but the query does not make sure there are no duplicate identifiers. When exporting data at moodle.org, we are seeing errors such as

      ++ Did you remember to make the first column something unique in your call to get_records? Duplicate value '1479296' found in column 'id'. ++
      * line 1256 of /lib/dml/mysqli_native_moodle_database.php: call to debugging()
      * line 788 of /mod/forum/classes/privacy/provider.php: call to mysqli_native_moodle_database->get_records_sql()
      * line 738 of /mod/forum/classes/privacy/provider.php: call to mod_forum\privacy\provider::export_all_posts_in_discussion()
      * line 612 of /mod/forum/classes/privacy/provider.php: call to mod_forum\privacy\provider::export_all_posts()
      * line ? of unknownfile: call to mod_forum\privacy\provider::export_user_data()
      * line 8023 of /lib/moodlelib.php: call to call_user_func_array()
      * line 578 of /privacy/classes/manager.php: call to component_class_callback()
      * line 611 of /privacy/classes/manager.php: call to core_privacy\manager::component_class_callback()
      * line 339 of /privacy/classes/manager.php: call to core_privacy\manager->handled_component_class_callback()
      * line 114 of /admin/tool/dataprivacy/classes/task/process_data_request_task.php: call to core_privacy\manager->export_user_data()
      * line 284 of /lib/cronlib.php: call to tool_dataprivacy\task\process_data_request_task->execute()
      * line 166 of /lib/cronlib.php: call to cron_run_inner_adhoc_task()
      * line 76 of /lib/cronlib.php: call to cron_run_adhoc_tasks()
      * line 61 of /admin/cli/cron.php: call to cron_run()
      

      Attachments

        Activity

          People

            Unassigned Unassigned
            mudrd8mz David Mudrák (@mudrd8mz)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:

              Clockify

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.