Competency cleanup upgrade step causes DML exception when loading user context

Test 1 (Delete stale evidence files) For this test we will need to do a before/after upgrade, or alternatively checkout the following commits: 310 : 1222c2125ee6be2dd828ae61e76926814027e4c2 39 : 2cd36e8ea0df01832cc3778f6cf35a6f69bb2b07 38 : 45d06fe9b6b92ad49427acf5145ae0e195954393 Before upgrade : Download setup_env.php and put it in your root folder. Open the browser, run that script and make note of the context id of each user. Now, upgrade moodle (or apply the version commit) If you checked out the commit then run the following command : git checkout MOODLE_310_STABLE Change the 310 to 39 for 3.9 and 38 for 3.8 branches. Upgrade php admin/cli/upgrade.php Open your database and run the following query replacing the context id number select * from mdl_files WHERE component = 'core_competency' AND filearea = 'userevidence' and contextid = {USER1_CONTEXTID_HERE} Make sure the query above does not return any records Replace the context id number to the user 2 context id and run that query again Make sure it returns the records for the user 2 evidence files. Test 2 (DML error) This test can be done after upgrading, you'll need to tweak version numbers again Run setup_env.php Open version.php and bump the version number (increment (+1) to whatever the last number is) Copy that whole version number. Open lib/db/upgrade.php and find the previous upgrade step (line 2172) and replace the version number check by the new ones: if ($oldversion < VERSIONNUMBERYOUCOPIEDHERE) { Also update the savepoint (line 2216): upgrade_main_savepoint(true, NEWVERSIONNUMBERHERE); In your moodle, run the upgrade on the web interface. Make sure you don't see any DML related error.