[MDL-68697] Translation caching is broken when there is no translation - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.9
Fix Version/s: 3.9
Component/s: H5P
Labels:
- regression
- triaged

Affected Branches:
MOODLE_39_STABLE
Fixed Branches:
MOODLE_39_STABLE
Epic Link:
H5P for Moodle 3.9
Pull from Repository:
git://github.com/andrewnicols/moodle.git
Pull Master Branch:
~~MDL-68697~~-master
Pull Master Diff URL:
https://github.com/andrewnicols/moodle/compare/206e179df5...MDL-68697-master
Testing Instructions:
Hide

Purge caches

Place the attached test_editor.php into your moodle root dir

Login as admin

Navigate to a course

Turn editing on

Add a new label

In the label click the H5P toolbar button

Upload the attached chart.h5p

Navigate to http://yoursite/test_editor.php

Edit the H5P activity you just created
Note: This is just to fill the cache initially

Confirm that it loads fully

Refresh the page

Confirm that it loads fully
Show
Purge caches Place the attached test_editor.php into your moodle root dir Login as admin Navigate to a course Turn editing on Add a new label In the label click the H5P toolbar button Upload the attached chart.h5p Navigate to http://yoursite/test_editor.php Edit the H5P activity you just created Note: This is just to fill the cache initially Confirm that it loads fully Refresh the page Confirm that it loads fully

Description

With the chart.h5p example there is no english translation. We store the negative result as a bool in the cache, but the cache cannot cope with a false value and sees that as a failure when calling unserialize, throwing an exception.

We cannot store a false value in a cache key it seems.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

chart.h5p
107 kB
13/May/20 9:24 AM
image-2020-05-14-10-31-46-828.png
48 kB
14/May/20 10:31 AM
test_editor.php
5 kB
13/May/20 9:24 AM

Issue Links

blocks

MDL-67810 Integrate content bank and H5P content creator

Closed

is a regression caused by

MDL-68271 H5P editor: support content-type translations

Closed

Activity

People

Assignee:: Andrew Lyons

Reporter:: Andrew Lyons

Peer reviewer:: Sara Arjona (@sarjona)

Integrator:: Víctor Déniz Falcón

Tester:: Janelle Barcega

Participants:: Andrew Lyons, CiBoT, Janelle Barcega, Sara Arjona (@sarjona), Víctor Déniz Falcón

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 13/May/20 9:18 AM

Updated:: 15/May/20 5:44 PM

Resolved:: 15/May/20 5:44 PM

Fix Release Date:: 15/Jun/20

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

1h 19m