Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68715

Condition: "Completion of other courses" is set without the course creator intervention

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Setup

      1. Login as admin
      2. Create a new course (Course A)
      3. Create another course (Course B)
      4. Navigate to Course A
      5. Add Course completion status block to the course
      6. Add a new label to the course
      7. Click on Course completion from the course Actions menu
      8. Expand Condition: Activity completion
      9. Tick the label you created and press Save changes
      10. Create a new user
      11. Enrol user as a student in the course
      12. Logout

      Complete activity

      1. Login as new user
      2. Navigate to Course A
      3. Manually mark the label as completed
      4. Logout

      Unlock completion

      1. Login as admin
      2. Navigate to Server > Tasks > Scheduled tasks in site administration
      3. Run the Calculate regular completion data task
      4. Navigate to Course A
      5. Click on Course completion from the course Actions menu
      6. Click Unlock completion options and delete user completion data and do not advance
      7. Re-run the Calculate regular completion data task
      8. In the Edit course completion settings form click Save changes
      9. In the Course completion status block click View course report
      10. Confirm report loads correctly (without exceptions)

      Regression test

      1. Navigate to Course A
      2. Click on Course completion from the course Actions menu
      3. Expand Condition: Completion of other courses
      4. Search for, and select, "Course B" in the Courses available field
      5. Press Save changes
      6. In the Course completion status block click View course report
      7. Confirm "Course B" is listed as a dependency
      8. Repeat steps 2-3, confirm "Course B" is still selected in the Courses available field
      9. Press Save changes
      10. In the Course completion status block click View course report
      11. Confirm "Course B" is listed as a dependency
      Show
      Setup Login as admin Create a new course (Course A) Create another course (Course B) Navigate to Course A Add Course completion status block to the course Add a new label to the course Click on Course completion from the course Actions menu Expand Condition: Activity completion Tick the label you created and press Save changes Create a new user Enrol user as a student in the course Logout Complete activity Login as new user Navigate to Course A Manually mark the label as completed Logout Unlock completion Login as admin Navigate to Server > Tasks > Scheduled tasks in site administration Run the Calculate regular completion data task Navigate to Course A Click on Course completion from the course Actions menu Click Unlock completion options and delete user completion data and do not advance Re-run the Calculate regular completion data task In the Edit course completion settings form click Save changes In the Course completion status block click View course report Confirm report loads correctly (without exceptions) Regression test Navigate to Course A Click on Course completion from the course Actions menu Expand Condition: Completion of other courses Search for, and select, "Course B" in the Courses available field Press Save changes In the Course completion status block click View course report Confirm "Course B" is listed as a dependency Repeat steps 2-3, confirm "Course B" is still selected in the Courses available field Press Save changes In the Course completion status block click View course report Confirm "Course B" is listed as a dependency
    • Affected Branches:
      MOODLE_38_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE, MOODLE_39_STABLE
    • Pull 3.8 Branch:
    • Pull 3.9 Branch:
    • Pull Master Branch:

      Description

      You need to follow the next steps

      Step 1:
      -create a course
      -add an LABEL activity then set "Activity completion" to "Students can manually mark the activity as completed"
      -open "Course completion" settings and, under "Condition: Activity completion", set the check mark next to the LABEL activity , then click button Save
      -add block "Course completion status"
      -on the antoher workstation enrol a student to the course and check mark LABEL activity by hand
      -WAIT for cron and do nothing else

      Step 2:
      -from admin open again "Course completion" settings
      -a warning appear at "Completion settings locked", which is normal
      -ignore it and click the button "Unlock completion options and delete user completion data"
      -WAIT for cron and do nothing else
      -click the button Save

      Step 3:
      -from admin open again "Course completion" settings
      -Condition: "Completion of other courses" is now set without your intervention and next to the "Courses available" is none set
      -from student workstation click on the button "More details" from block "Course completion status" and a beautiful error will appear.

      This error is because the table "mdl_course_completion_criteria" contain a wrong record, sometimes twice!!!, with field criteritype set to 8 and the others fields NULL.

       

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              pholden Paul Holden
              Reporter:
              salex S. Alex
              Peer reviewer:
              Simey Lameze
              Integrator:
              Sara Arjona (@sarjona)
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Sam Marshall, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Sep/20

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 hours, 30 minutes
                  5h 30m