Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68731

Forum digest processing does not mark posts as read

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.7.6, 3.8.3, 3.8.4, 3.9, 3.9.1
    • Fix Version/s: 3.8.5, 3.9.2
    • Component/s: Forum
    • Testing Instructions:
      Hide

      As admin:

      1. Ensure the Forum module setting "Manual message read marking" is disabled.
      2. In a course, create a force-subscribed forum.
      3. Enrol a student user in the course.
      4. Configure the student user with forum digest type "complete", read tracking "yes", and "mark post as read" when sending post notifications.
      5. Create a post in the forum with "no editing-time delay" set.
      6. Log in as the student, view the forum and observe the unread post.
      7. Run: php admin/tool/task/cli/schedule_task.php --execute='mod_forum\task\cron_task'
        Observe the task output reads "Queued 1 digests".
      8. Fudge the queued adhoc tasks via SQL so they can be executed immediately:
        UPDATE mdl_task_adhoc SET nextruntime=1
      9. Run: php admin/tool/task/cli/adhoc_task.php --execute
        Observe that the mod_forum\task\send_user_digests task ran.
      10. While still logged in as the student, reload the same forum page.
        • Before fix: observe the same unread post remains.
        • After fix: observe no unread posts are shown.

      Confirm the alternative behaviour. As admin:

      1. Ensure the Forum module setting "Manual message read marking" is enabled.
      2. Execute steps 2 through 9 from above.
      3. While still logged in as the student, reload the same forum page.
        • Before fix: observe no unread posts are shown.
        • After fix: observe the same unread post remains.
      Show
      As admin: Ensure the Forum module setting "Manual message read marking" is disabled. In a course, create a force-subscribed forum. Enrol a student user in the course. Configure the student user with forum digest type "complete", read tracking "yes", and "mark post as read" when sending post notifications. Create a post in the forum with "no editing-time delay" set. Log in as the student, view the forum and observe the unread post. Run: php admin/tool/task/cli/schedule_task.php --execute='mod_forum\task\cron_task' Observe the task output reads "Queued 1 digests". Fudge the queued adhoc tasks via SQL so they can be executed immediately: UPDATE mdl_task_adhoc SET nextruntime=1 Run: php admin/tool/task/cli/adhoc_task.php --execute Observe that the mod_forum\task\send_user_digests task ran. While still logged in as the student, reload the same forum page. Before fix: observe the same unread post remains. After fix: observe no unread posts are shown. Confirm the alternative behaviour. As admin: Ensure the Forum module setting "Manual message read marking" is enabled. Execute steps 2 through 9 from above. While still logged in as the student, reload the same forum page. Before fix: observe no unread posts are shown. After fix: observe the same unread post remains.
    • Affected Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE, MOODLE_39_STABLE
    • Pull from Repository:
    • Pull 3.8 Branch:
    • Pull 3.9 Branch:
    • Pull Master Branch:

      Description

      When the Forum module setting "Manual message read marking" is disabled, for any users with forum read tracking enabled and complete digest type set, posts included in the digest are not marked as read upon generation of the message.

      Similarly, with "Manual message read marking" enabled, posts are instead marked as read when they should be left alone.

        Attachments

          Activity

            People

            Assignee:
            jonof Jonathon Fowler
            Reporter:
            jonof Jonathon Fowler
            Peer reviewer:
            Simey Lameze
            Integrator:
            Andrew Nicols
            Tester:
            Anna Carissa Sadia
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              14/Sep/20

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 6 hours, 54 minutes
                6h 54m