Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68749

Toggle switches display incorrectly in RTL mode

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.9, 3.9.2, 3.10
    • Fix Version/s: 3.9.3
    • Component/s: Forum, Themes
    • Labels:
    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_39_STABLE
    • Pull 3.9 Branch:
      MDL-68749-39-2
    • Pull 3.10 Branch:
      MDL-68749-310-2
    • Pull Master Branch:
      MDL-68749-master-2
    • Testing Instructions:
      Hide

      Please, test in all the supported browsers:

      • Chrome, Firefox, Safari, Edge in 3.10/master
      • All the above plus IE11 in 3.9

      Setup

      1. Have a course with a forum activity containing a couple of discussions.
      2. Have messaging enabled on the site.
      3. Have at least one LTR and one RTL language pack installed (eg English and Hebrew).
      4. Set your site's theme to Boost.
      5. Clear site caches.

      Testing

      1. Log in as a teacher on the course, set the language to the LTR (eg English) language if it isn't already.
      2. Open the forum activity.
      3. In the Subscribe column of the discussion list, click on one of the switches.
      4. CONFIRM both the on and off switches look correct (ie the circle in the switch sits inside the switch in both positions, and that it moves from one side to the other when toggled, background colour switches from white to blue when turned on etc).
      5. Open the messaging drawer.
      6. Click the settings cog.
      7. Toggle the "Use enter to send" switch and CONFIRM the switch looks correct in both positions.
      8. Switch to the RTL language (eg Hebrew) and repeat steps 2-7, CONFIRMING in the various steps that the switches appear correct in both on and off positions.
      9. Switch your theme to Classic and repeat steps 2-7 in the RTL language, to CONFIRM switches look correct in both themes (the sizing/spacing is slightly different between them).
      Show
      Please, test in all the supported browsers: Chrome, Firefox, Safari, Edge in 3.10/master All the above plus IE11 in 3.9 Setup Have a course with a forum activity containing a couple of discussions. Have messaging enabled on the site. Have at least one LTR and one RTL language pack installed (eg English and Hebrew). Set your site's theme to Boost. Clear site caches. Testing Log in as a teacher on the course, set the language to the LTR (eg English) language if it isn't already. Open the forum activity. In the Subscribe column of the discussion list, click on one of the switches. CONFIRM both the on and off switches look correct (ie the circle in the switch sits inside the switch in both positions, and that it moves from one side to the other when toggled, background colour switches from white to blue when turned on etc). Open the messaging drawer. Click the settings cog. Toggle the "Use enter to send" switch and CONFIRM the switch looks correct in both positions. Switch to the RTL language (eg Hebrew) and repeat steps 2-7, CONFIRMING in the various steps that the switches appear correct in both on and off positions. Switch your theme to Classic and repeat steps 2-7 in the RTL language, to CONFIRM switches look correct in both themes (the sizing/spacing is slightly different between them).

      Description

      Clicking the "subscribe to discussion posts" toggle, display the "ON" icon off the element, in RTL mode.
      OFF icon looks fine.

      Example: https://qa.moodledemo.net/mod/forum/view.php?id=20&lang=he

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              michaelh Michael Hawkins
              Reporter:
              nadavkav Nadav Kavalerchik
              Peer reviewer:
              Shamim Rezaie Shamim Rezaie
              Integrator:
              Víctor Déniz Falcón Víctor Déniz Falcón
              Tester:
              Janelle Barcega Janelle Barcega
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Huong Nguyen, Bas Brands, Mathew May
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Nov/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 1 hour, 12 minutes
                  1d 1h 12m