Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68760

PHPunit failures fromtest_timezone_lang_strings not helpful, and America/Nuuk string missing

XMLWordPrintable

    • MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
    • MOODLE_37_STABLE, MOODLE_38_STABLE
    • Hide

      Not easy to test. When Travis-CI fails this test (which seems to happen only randomly) then check to see if the message is clear.)

      Show
      Not easy to test. When Travis-CI fails this test (which seems to happen only randomly) then check to see if the message is clear.)

      To reproduce:

      1. Try to work on Moodle code.
      2. Let Travis run PHPunit to see if your code is ready for integration.

      Expect result: PHPunit passes because my code is awesome

      Acutal result: core_date_testcase::test_timezone_lang_strings Failed asserting that false is true.

      That message does not help you understand what the problem is. It needs to be improved.

      Edited (Eloy): For the records the problems reported with 'America/Nuuk' come with the update to IANA timezone database 2020.a (that was packaged into PHP's timezonedb 2020.1 some days ago). Sites using that timezonedb (like travis, that recently updated to PHP 7.4.6) are the ones failing.

      Edited 2 (Eloy): Other sources of information that can be useful (not needed in this issue but in others, timezone related):

            timhunt Tim Hunt
            timhunt Tim Hunt
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            CiBoT CiBoT
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 11 minutes
                1h 11m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.