[MDL-68765] Login form (loginform.mustache) has DIV tag double CLASS attributes - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.7.6, 3.8.3, 3.9
Fix Version/s: 3.8.4
Component/s: Accessibility, Authentication
Labels:
- ci
- patch

Affected Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_38_STABLE
Pull from Repository:
https://github.com/ised-isde-canada/moodle.git
Pull Master Branch:
~~MDL-68765~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...ised-isde-canada:MDL-68765-master
Difficulty:
Easy
Testing Instructions:
Hide

Using a Moodle site which has been configured with OAuth2 (Google in this example) and has a related button visible on the login page:

Go to the Moodle login page of your site.

Using your web browse's developer tools, inspect the line above the Google button that says Log in using your account on:, Depending on whether or not you already integrated ~~MDL-68766~~, this will either be an H6 or an H3.

The very next line should be a div containing a single class attribute:
<div class="potentialidplist mt-3">

If this is what you see, the test has been a success.
Show
Using a Moodle site which has been configured with OAuth2 (Google in this example) and has a related button visible on the login page: Go to the Moodle login page of your site. Using your web browse's developer tools, inspect the line above the Google button that says Log in using your account on: , Depending on whether or not you already integrated MDL-68766 , this will either be an H6 or an H3. The very next line should be a div containing a single class attribute: <div class="potentialidplist mt-3"> If this is what you see, the test has been a success.

Description

In the hasidentityproviders section of the Moodle core /lib/templates/loginform.mustache login form, there is a div class with two separate class attributes.

<div class="potentialidplist" class="mt-3">

This is not valid in HTML5 and is therefore also an accessibility issue. The classes listed in the two class attributes should be combined into a single class attribute.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

68465-39.png
196 kB
27/May/20 12:51 PM
68765-38.png
251 kB
27/May/20 12:51 PM

Activity

People

Assignee:: Michael Milette

Reporter:: Michael Milette

Peer reviewer:: Luca Bösch

Integrator:: Andrew Lyons

Tester:: Andrew Lyons

Participants:: Andrew Lyons, CiBoT, Luca Bösch, Michael Milette

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 19/May/20 12:43 PM

Updated:: 29/May/20 7:27 PM

Resolved:: 29/May/20 7:27 PM

Fix Release Date:: 13/Jul/20

Time Tracking

Estimated:

Remaining:

Logged:

40m