Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68765

Login form (loginform.mustache) has DIV tag double CLASS attributes

    XMLWordPrintable

Details

    • MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • MOODLE_38_STABLE
    • MDL-68765-master
    • Easy
    • Hide

      Using a Moodle site which has been configured with OAuth2 (Google in this example) and has a related button visible on the login page:

      1. Go to the Moodle login page of your site.
      2. Using your web browse's developer tools, inspect the line above the Google button that says Log in using your account on:, Depending on whether or not you already integrated MDL-68766, this will either be an H6 or an H3.
      3. The very next line should be a div containing a single class attribute:
        <div class="potentialidplist mt-3">

      If this is what you see, the test has been a success.

      Show
      Using a Moodle site which has been configured with OAuth2 (Google in this example) and has a related button visible on the login page: Go to the Moodle login page of your site. Using your web browse's developer tools, inspect the line above the Google button that says  Log in using your account on: , Depending on whether or not you already integrated MDL-68766 , this will either be an H6 or an H3. The very next line should be a div containing a single class attribute: <div class="potentialidplist mt-3"> If this is what you see, the test has been a success.

    Description

      In the hasidentityproviders section of the Moodle core /lib/templates/loginform.mustache login form, there is a div class with two separate class attributes.

      <div class="potentialidplist" class="mt-3">

      This is not valid in HTML5 and is therefore also an accessibility issue. The classes listed in the two class attributes should be combined into a single class attribute.

      Attachments

        1. 68765-38.png
          68765-38.png
          251 kB
        2. 68465-39.png
          68465-39.png
          196 kB

        Activity

          People

            michael-milette Michael Milette
            michael-milette Michael Milette
            Luca Bösch Luca Bösch
            Andrew Lyons Andrew Lyons
            Andrew Lyons Andrew Lyons
            David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              13/Jul/20

              Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 40 minutes
                40m