[MDL-68766] Login form: "Log in using your account on:" should be h3, not h6 - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.7.6, 3.8.3, 3.9
Fix Version/s: 3.8.6, 3.9.3
Component/s: Accessibility, Authentication
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_38_STABLE, MOODLE_39_STABLE
Pull from Repository:
https://github.com/ised-isde-canada/moodle.git
Pull 3.9 Branch:
~~MDL-68766~~-M39
Pull 3.9 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_39_STABLE...michael-milette:MDL-68766-M39
Pull Master Branch:
~~MDL-68766~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master..michael-milette:MDL-68766-master
Difficulty:
Easy
Testing Instructions:
Hide

Using a Moodle site which has been configured with OAuth2 (Google in this example) and has a related button visible on the login page:

Go to the Moodle login page of your site.

Using your web browse's developer tools, inspect the line above the Google button that says Log in using your account on:.

This heading should now be an H3 with a class of H6 to ensure the text remains the same size visually:
<h3 class="h6 mt-2">#str potentialidps, auth /str</h3>

If this is what you see, the test has been a success.
Show
Using a Moodle site which has been configured with OAuth2 (Google in this example) and has a related button visible on the login page: Go to the Moodle login page of your site. Using your web browse's developer tools, inspect the line above the Google button that says Log in using your account on: . This heading should now be an H3 with a class of H6 to ensure the text remains the same size visually: <h3 class="h6 mt-2"> #str potentialidps, auth /str </h3> If this is what you see, the test has been a success.

Description

The heading for the hasidentityproviders section of the /lib/templates/loginform.mustache is an H6. However, it is a sub-heading of login form's H2 section and should therefore be an H3 though it can still be styled with the font size of an H6.

This is an accessibility issue and a failure of WCAG 2.1 Success Criterion 1.3.1: Info and Relationships. For more information, see technique H42: Using h1-h6 to identify headings.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Screen Shot 2020-10-21 at 1.20.48 pm.png
240 kB
21/Oct/20 1:48 PM

Activity

People

Assignee:: Michael Milette

Reporter:: Michael Milette

Peer reviewer:: Neill Magill

Integrator:: Adrian Greeve

Tester:: Mathew May

Participants:: Adrian Greeve, CiBoT, Mathew May, Michael Milette, Neill Magill

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 19/May/20 12:59 PM

Updated:: 30/Oct/20 12:06 AM

Resolved:: 23/Oct/20 9:06 PM

Fix Release Date:: 9/Nov/20

Time Tracking

Estimated:

Remaining:

Logged:

1h 40m