Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68808

MDL-57680 breaks form-autocomplete in IE11

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Prerequisites:

      1. Course (any format)
      2. Any number of users enrolled on the course
      3. Admin/manager login
      4. IE11 for testing fix (plus other supported browsers to check for regression)
      5. Note this only have to be tested on 38_STABLE and 39_STABLE.

      1) Visit any course page in a Moodle site as admin/manager and navigate to the 'Enrolled users' screen (Select Cog, 'More..' under 'Course administration' > 'Users' tab)

      2) In the Participants page within the ‘Search keyword or select filter’ text box/menu press the downward triangle, from the list of options and select a role. The role will appear above the ‘Search keyword…’ text box. The page should refresh and only display users with the role selected. Previous behaviour in IE11 was to do nothing and show console errors.

      3) If you then click the 'x' on the role listed above the search box to clear the filter, the page should refresh without role filter applied. Previous behaviour in IE11 was to generate a ‘TypeError’ message which appeared as a pop-up window.

      Show
      Prerequisites : Course (any format) Any number of users enrolled on the course Admin/manager login IE11 for testing fix (plus other supported browsers to check for regression) Note this only have to be tested on 38_STABLE and 39_STABLE. 1) Visit any course page in a Moodle site as admin/manager and navigate to the 'Enrolled users' screen (Select Cog, 'More..' under 'Course administration' > 'Users' tab) 2) In the Participants page within the ‘Search keyword or select filter’ text box/menu press the downward triangle, from the list of options and select a role. The role will appear above the ‘Search keyword…’ text box. The page should refresh and only display users with the role selected. Previous behaviour in IE11 was to do nothing and show console errors. 3) If you then click the 'x' on the role listed above the search box to clear the filter, the page should refresh without role filter applied. Previous behaviour in IE11 was to generate a ‘TypeError’ message which appeared as a pop-up window.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE, MOODLE_39_STABLE
    • Pull 3.8 Branch:
      wip-MDL-68808-MOODLE_38_STABLE
    • Pull 3.9 Branch:
      wip-MDL-68808-MOODLE_39_STABLE

      Description

      The changes made in MDL-57680 cause the form-autocomplete component to throw the following error in the console when selecting or changing options using Internet Explorer 11.

      jQuery.Deferred exception: Object doesn't support this action TypeError: Object doesn't support this action
      at k (https://domain/lib/requirejs.php/1590141336/core/first.js:53:1430)
      at Anonymous function (https://domain/lib/requirejs.php/1590141336/core/first.js:53:4656)
      at j (https://domain/lib/javascript.php/1590141336/lib/jquery/jquery-3.2.1.min.js:1:29992)
      at Anonymous function (https://domain/lib/javascript.php/1590141336/lib/jquery/jquery-3.2.1.min.js:1:30313) undefined

      This presents to the end user as pop-up with the error message abbreviated to

      Object doesn't support this action

      Reverting the changes made restores functionality as per 3.7.5.

      Steps to reproduce:

      1) Visit a course page in Moodle and navigate to the Participants page by pressing the hamburger menu and selecting ‘Participants’ from the pop-up menu.

      2) In the Participants page within the ‘Search keyword or select filter’ text box/menu press the downward triangle, from the list of options select a role. The role will appear above the ‘Search keyword…’ text box. The page should refresh and only display users with the role. However, it does nothing.

      3) If you then click the x of the role to clear the filter it will generate an ‘TypeError’ message which appears as a pop-up window.

        Attachments

        1. DebuggerWindow.PNG
          DebuggerWindow.PNG
          145 kB
        2. screenshot-1.png
          screenshot-1.png
          167 kB
        3. UserErrorMessage.PNG
          UserErrorMessage.PNG
          70 kB

          Issue Links

            Activity

              People

              Assignee:
              jp76 Jason Platts
              Reporter:
              trendells Simon Trendell
              Peer reviewer:
              Jake Dallimore
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              1 Vote for this issue
              Watchers:
              10 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Nov/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 33 minutes
                  2h 33m