[MDL-68808] MDL-57680 breaks form-autocomplete in IE11 - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.7.6, 3.8.4, 3.9.2
Fix Version/s: 3.8.6, 3.9.3
Component/s: Forms Library
Labels:

Affected Branches:
MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_38_STABLE, MOODLE_39_STABLE
Pull from Repository:
https://github.com/jason-platts/moodle
Pull 3.9 Branch:
wip-~~MDL-68808~~-MOODLE_39_STABLE
Pull 3.9 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_39_STABLE...jason-platts:wip-MDL-68808-MOODLE_39_STABLE
Difficulty:
Easy
Testing Instructions:
Hide

Prerequisites:

Course (any format)

Any number of users enrolled on the course

Admin/manager login

IE11 for testing fix (plus other supported browsers to check for regression)

Note this only have to be tested on 38_STABLE and 39_STABLE.

1) Visit any course page in a Moodle site as admin/manager and navigate to the 'Enrolled users' screen (Select Cog, 'More..' under 'Course administration' > 'Users' tab)

2) In the Participants page within the ‘Search keyword or select filter’ text box/menu press the downward triangle, from the list of options and select a role. The role will appear above the ‘Search keyword…’ text box. The page should refresh and only display users with the role selected. Previous behaviour in IE11 was to do nothing and show console errors.

3) If you then click the 'x' on the role listed above the search box to clear the filter, the page should refresh without role filter applied. Previous behaviour in IE11 was to generate a ‘TypeError’ message which appeared as a pop-up window.
Show
Prerequisites : Course (any format) Any number of users enrolled on the course Admin/manager login IE11 for testing fix (plus other supported browsers to check for regression) Note this only have to be tested on 38_STABLE and 39_STABLE. 1) Visit any course page in a Moodle site as admin/manager and navigate to the 'Enrolled users' screen (Select Cog, 'More..' under 'Course administration' > 'Users' tab) 2) In the Participants page within the ‘Search keyword or select filter’ text box/menu press the downward triangle, from the list of options and select a role. The role will appear above the ‘Search keyword…’ text box. The page should refresh and only display users with the role selected. Previous behaviour in IE11 was to do nothing and show console errors. 3) If you then click the 'x' on the role listed above the search box to clear the filter, the page should refresh without role filter applied. Previous behaviour in IE11 was to generate a ‘TypeError’ message which appeared as a pop-up window.

Description

The changes made in ~~MDL-57680~~ cause the form-autocomplete component to throw the following error in the console when selecting or changing options using Internet Explorer 11.

jQuery.Deferred exception: Object doesn't support this action TypeError: Object doesn't support this action

at k (https://domain/lib/requirejs.php/1590141336/core/first.js:53:1430)

at Anonymous function (https://domain/lib/requirejs.php/1590141336/core/first.js:53:4656)

at j (https://domain/lib/javascript.php/1590141336/lib/jquery/jquery-3.2.1.min.js:1:29992)

at Anonymous function (https://domain/lib/javascript.php/1590141336/lib/jquery/jquery-3.2.1.min.js:1:30313) undefined

This presents to the end user as pop-up with the error message abbreviated to

Object doesn't support this action

Reverting the changes made restores functionality as per 3.7.5.

Steps to reproduce:

1) Visit a course page in Moodle and navigate to the Participants page by pressing the hamburger menu and selecting ‘Participants’ from the pop-up menu.

2) In the Participants page within the ‘Search keyword or select filter’ text box/menu press the downward triangle, from the list of options select a role. The role will appear above the ‘Search keyword…’ text box. The page should refresh and only display users with the role. However, it does nothing.

3) If you then click the x of the role to clear the filter it will generate an ‘TypeError’ message which appears as a pop-up window.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

DebuggerWindow.PNG
145 kB
22/May/20 6:36 PM
screenshot-1.png
167 kB
07/Oct/20 9:54 AM
UserErrorMessage.PNG
70 kB
22/May/20 6:36 PM

Issue Links

is a regression caused by

MDL-57680 Autocomplete Form API: Can't clear single-select value, and does not fire change event

Closed

Activity

People

Assignee:: Jason Platts

Reporter:: Simon Trendell

Peer reviewer:: Jake Dallimore

Integrator:: Eloy Lafuente (stronk7)

Tester:: Janelle Barcega

Participants:: CiBoT, Eloy Lafuente (stronk7), Jake Dallimore, Janelle Barcega, Jason Platts, Joseph Baxter, Simon Trendell, Tim Hunt

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 1 Vote for this issue

Watchers:: 9 Start watching this issue

Dates

Created:: 22/May/20 6:36 PM

Updated:: 09/Oct/20 5:50 PM

Resolved:: 09/Oct/20 5:50 PM

Fix Release Date:: 9/Nov/20

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

2h 33m