Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68844

Static elements missalignment in form groups

    XMLWordPrintable

Details

    • MOODLE_38_STABLE, MOODLE_39_STABLE
    • MOODLE_38_STABLE
    • MDL-68844-master
    • Hide
      1. Put formtest.php attached file into the root of your Moodle codebase.
      2. Open it in the browser.
      3. Check that layout issue is fixed: "Just a static text" should be vertically centered.
      4. Verify that any existing group layout is not broken. For instance, navigate to /admin/user.php page and click on "Show more..."
      5. Make sure the layout is not broken.
      Show
      Put  formtest.php  attached file into the root of your Moodle codebase. Open it in the browser. Check that layout issue is fixed: "Just a static text" should be vertically centered. Verify that any existing group layout is not broken. For instance, navigate to /admin/user.php page and click on "Show more..." Make sure  the layout is not broken.

    Description

      This is probably a regression introduced by MDL-67968.

      New 'div' elements added in 'element-group.mustache' and 'element-group-inline.mustache' caused static elements missalignment.

       Without the patch:

      With the patch:

      Adding 'align-items-center' class to the 'd-flex' new div elements solves the problem.

       

      Attachments

        1. formtest.php
          2 kB
        2. image-2020-05-27-13-05-58-640.png
          image-2020-05-27-13-05-58-640.png
          16 kB
        3. image-2020-05-27-13-07-26-684.png
          image-2020-05-27-13-07-26-684.png
          15 kB
        4. MDL-68844.png
          MDL-68844.png
          215 kB

        Issue Links

          Activity

            People

              mikelmartíncorrales Mikel Martín Corrales
              mikelmartíncorrales Mikel Martín Corrales
              Paul Holden Paul Holden
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Anna Carissa Sadia Anna Carissa Sadia
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                13/Jul/20

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 hours, 10 minutes
                  5h 10m