[MDL-68868] Final deprecation of participants unified filter - Moodle Tracker

XML

Word

Printable

Details

Type: Task
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: Future Dev
Fix Version/s: 4.1
Component/s: Course
Labels:
- ci
- cinfo
- hqteam_hedgehog
- release_notes
- triaged

Fixed Branches:
MOODLE_401_STABLE
Epic Link:
4.1 deprecations
Pull from Repository:
https://github.com/davewoloszyn/moodle.git
Pull Master Branch:
~~MDL-68868~~-master
Pull Master Diff URL:
https://github.com/davewoloszyn/moodle/compare/24f97edd91...MDL-68868-master
Testing Instructions:
Hide

Open a terminal and go to your moodle instance's root directory.

Search for unified_filter through the codebase

git grep unified_filter

Confirm that the only instances returned are from

user/renderer.php - in the unified_filter() method which now throws a coding exception

user/upgrade.txt - which notes about final deprecation

Search for ~~MDL-68868~~ from the codebase

git grep MDL-68868

Confirm that no instances are returned.
Show
Open a terminal and go to your moodle instance's root directory. Search for unified_filter through the codebase git grep unified_filter Confirm that the only instances returned are from user/renderer.php - in the unified_filter() method which now throws a coding exception user/upgrade.txt - which notes about final deprecation Search for MDL-68868 from the codebase git grep MDL-68868 Confirm that no instances are returned.

Story Points:
2
Sprint:
Team Hedgehog 4.1 sprint 0.4B, Team Hedgehog 4.1 sprint 0 rev

Description

The following final deprecations need to be performed in relation to the old participants unified filter, which was replaced by the participants filter and table filtersets in Moodle 3.9 under ~~MDL-68612~~.

JavaScript
The following can be removed:

user/amd/src/unified_filter.js
user/amd/src/unified_filter_datasource.js

Mustache

user/templates/unified_filter.mustache can be removed.

Renderer

user/classes/output/unified_filter.php should follow final deprecation procedures as per ~~MDLSITE-6729~~ (ie be completely removed).

Renderable

In user/renderer.php, the unified_filter() function only should follow final deprecation procedures (eg throw an exception).

Other related deprecations performed in ~~MDL-68612~~ are already covered by other general 4.3 final deprecation issues (library functions in MDL-67345, string in ~~MDL-67347~~).

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-68868.png
50 kB
21/Oct/22 1:07 PM

Issue Links

has to be done after

MDL-68612 Remove the previous (unified) filter from the participants page and deprecate relevant code

Closed

Activity

People

Assignee:: David Woloszyn

Reporter:: Michael Hawkins

Peer reviewer:: Huong Nguyen

Integrator:: Jun Pataleta

Tester:: John Edward Pedregosa

Participants:: CiBoT, David Woloszyn, Huong Nguyen, John Edward Pedregosa, Jun Pataleta, Michael Hawkins

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Laurent David, Sabina Abellan, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 29/May/20 12:55 PM

Updated:: 25/Nov/22 2:19 PM

Resolved:: 21/Oct/22 9:16 PM

Fix Release Date:: 28/Nov/22

Time Tracking

Estimated:

Remaining:

Logged:

5h 45m