Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68875

moodle_content_writer_test failures with Windows

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.8.3, 3.9
    • Fix Version/s: 3.8.4
    • Component/s: Privacy, Unit tests
    • Labels:

      Description

      We have started recently to get 3 new failures with windows phpunit (and also one error, although that one, depending of the Windows environment, passes).

      See, few days ago, passing: https://travis-ci.org/github/stronk7/moodle/builds/690077643
      And, since 2 days ago, failing: https://travis-ci.org/github/stronk7/moodle/builds/691495213

      So, something has landed recently leading to those new failures (and maybe error).

      This issue is about to find it and, ideally, get a fix to be back to green.

      Moodle 3.9dev+ (Build: 20200522), a706f7161fea0081dfe5a331ea21605bf488140c
      Php: 7.3.5, pgsql: 10.6, OS: Windows NT 10.0 AMD64
      PHPUnit 7.5.20 by Sebastian Bergmann and contributors.
       
      Runtime:       PHP 7.3.5
      Configuration: C:\Users\stronk7\git_moodle\integration\phpunit.xml
       
      ...........F.F.F...............................E....              52 / 52 (100%)
       
      Time: 22.14 seconds, Memory: 72.00 MB
       
      There was 1 error:
       
      1) moodle_content_writer_test::test_export_user_preference_long_filename with data set "More than 100 characters" ('Etiam sit amet dui vel leo bl...scipit', 'Etiam sit amet dui vel leo bl...a5030d', 'value')
      ZipArchive::close(): Read error: No such file or directory
       
      C:\Users\stronk7\git_moodle\integration\lib\filestorage\zip_archive.php:225
      C:\Users\stronk7\git_moodle\integration\lib\filestorage\zip_packer.php:154
      C:\Users\stronk7\git_moodle\integration\privacy\classes\local\request\moodle_content_writer.php:688
      C:\Users\stronk7\git_moodle\integration\privacy\tests\moodle_content_writer_test.php:1225
      C:\Users\stronk7\git_moodle\integration\privacy\tests\moodle_content_writer_test.php:1177
      C:\Users\stronk7\git_moodle\integration\lib\phpunit\classes\advanced_testcase.php:80
       
      To re-run:
       vendor/bin/phpunit -v "moodle_content_writer_test" privacy/tests/moodle_content_writer_test.php
       
      --
       
      There were 3 failures:
       
      1) moodle_content_writer_test::test_export_file with data set "longpath" ('attachments', '12', '/path/within/a/path/within/a/path/', 'testfile.txt', 'An example file content')
      Failed asserting that false is true.
       
      C:\Users\stronk7\git_moodle\integration\privacy\tests\moodle_content_writer_test.php:466
      C:\Users\stronk7\git_moodle\integration\lib\phpunit\classes\advanced_testcase.php:80
       
      To re-run:
       vendor/bin/phpunit -v "moodle_content_writer_test" privacy/tests/moodle_content_writer_test.php
       
      2) moodle_content_writer_test::test_export_file with data set "filewithspaces" ('submission_attachments', 1, '/path with/some spaces/', 'test file.txt', 'An example file content')
      Failed asserting that false is true.
       
      C:\Users\stronk7\git_moodle\integration\privacy\tests\moodle_content_writer_test.php:466
      C:\Users\stronk7\git_moodle\integration\lib\phpunit\classes\advanced_testcase.php:80
       
      To re-run:
       vendor/bin/phpunit -v "moodle_content_writer_test" privacy/tests/moodle_content_writer_test.php
       
      3) moodle_content_writer_test::test_export_file with data set "UTF8" ('submission_content', 2, '/Žluťoučký/', 'koníček.txt', 'koníček')
      Failed asserting that false is true.
       
      C:\Users\stronk7\git_moodle\integration\privacy\tests\moodle_content_writer_test.php:466
      C:\Users\stronk7\git_moodle\integration\lib\phpunit\classes\advanced_testcase.php:80
       
      To re-run:
       vendor/bin/phpunit -v "moodle_content_writer_test" privacy/tests/moodle_content_writer_test.php
       
      ERRORS!
      Tests: 52, Assertions: 192, Errors: 1, Failures: 3.
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              stronk7 Eloy Lafuente (stronk7)
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Peer reviewer:
              Sara Arjona (@sarjona)
              Integrator:
              Jake Dallimore
              Tester:
              CiBoT
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Jul/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 10 minutes
                  3h 10m