Database should use its own "RSS feed for this activity" string

Description

Database should use its own "RSS feed for this activity" string.
It uses the forum "RSS feed for this activity" string.

When a locale uses it and tweaks it to say forum, that breaks the database's string
(verify the string in German saying "RSS Feed für dieses Forum" meaning "RSS feed for this forum").

Testing Instructions

  1. As admin, allow RSS feeds with the enablerssfeeds option.

  2. Allow RSS feeds for the database activity with the data_enablerssfeeds option.

  3. Insert a database to your course.

  4. Enable the database to have a RSS feed.

  5. Go to the database.

  6. Verify the string in the action menu says "RSS feed for this activity".

  7. In Administration → Language customization change the mod_data rsstype string to "RSS feed for this database" and save.

  8. Go to the database.

  9. Verify the string in the action menu says "RSS feed for this database".

Automated test results

None

Pre-check results

None

Workaround

None

Attachments

2

Activity

noreply
4 February 2021 at 14:22

Thanks for your contributions! This change is now available from the main moodle.git repository and will shortly be available on download.moodle.org.

Closing as fixed!

Anna Carissa Sadia
3 February 2021 at 06:38

Confirmed and verified fixed in 3.9, 3.10, 3.11, and master.

Andrew Lyons
3 February 2021 at 01:42

Hi Luca,

Thank you for working on this issue. It has now been integrated \o/

Integrated to 3.9, 3.10, 3.11, and master. Over to testing.

noreply
1 February 2021 at 03:42

Code verified against automated checks.

Checked https://moodle.atlassian.net/browse/MDL-68893#icft=MDL-68893 using repository: git://github.com/lucaboesch/moodle.git

More information about this report

noreply
31 January 2021 at 23:14

Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

Fixed

Details

Priority

Affects versions

Components

Labels

Assignee

Reporter

Peer reviewer

Integrator

Fix versions

Tester

Participants

Andrew Lyons
Anna Carissa Sadia
Luca Bösch
noreply
Paul Holden
Peter Dias

Pull from Repository

Pull Main Diff URL

Pull Main Branch

Clockify

Created 2 June 2020 at 08:29
Updated 4 February 2021 at 14:22
Resolved 4 February 2021 at 14:22