Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68902

HTML tags are displayed in H5P activity results title when formatstringstriptags is disabled

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.9
    • Fix Version/s: 3.9
    • Component/s: H5P
    • Testing Instructions:
      Hide

      Testing covered by behat test mod/h5pactivity/tests/behat/result_fillin.feature and mod/h5pactivity/tests/behat/result_longfillin.feature

      https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/7075/ 

      Manual testing 1

      1. As admin, disable the general setting "formatstringstriptags"
      2. Create a course with an H5P activity using the provided h5p package essay-4-166755.h5p
      3. Enrol a user as student
      4. Login as this student and write this text as a solution:
        1. The book is about a guy called Bilbo. One day, he gets some unexpected visitors: Gandalf, the wizard and nine dwarfs. Some of them had strange names such as Gloin or Dori.
      5. Press Check button
        1. Check that your score is 50/80
      6. Refresh the page
      7. Go to the "View my attempts"
      8. Click on the view report form the attempt
        1. Check that the essay title don't show any HTML tags.

      Manual testing 2

      1. As admin, enter the course form the previous test and create  a H5P activity using the filltheblanks.h5p package
      2. Login as student and go to the activity
      3. Enter this values:
        1. Gap 1: Narnia
        2. Gap 2: Xadia
        3. Gap 3: King landing
        4. Gap 4: Canberra
      4. Refresh the page and go to "my attempts"
      5. Click on the view report from the attempt
        1. Check that no HTML tags is displayed in the report.
      Show
      Testing covered by behat test mod/h5pactivity/tests/behat/result_fillin.feature and mod/h5pactivity/tests/behat/result_longfillin.feature https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/7075/   Manual testing 1 As admin, disable the general setting "formatstringstriptags" Create a course with an H5P activity using the provided h5p package  essay-4-166755.h5p Enrol a user as student Login as this student and write this text as a solution: The book is about a guy called Bilbo. One day, he gets some unexpected visitors: Gandalf, the wizard and nine dwarfs. Some of them had strange names such as Gloin or Dori. Press Check button Check that your score is 50/80 Refresh the page Go to the "View my attempts" Click on the view report form the attempt Check that the essay title don't show any HTML tags. Manual testing 2 As admin, enter the course form the previous test and create  a H5P activity using the  filltheblanks.h5p  package Login as student and go to the activity Enter this values: Gap 1: Narnia Gap 2: Xadia Gap 3: King landing Gap 4: Canberra Refresh the page and go to "my attempts" Click on the view report from the attempt Check that no HTML tags is displayed in the report.
    • Affected Branches:
      MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_39_STABLE
    • Pull Master Branch:
      MDL-68902-master
    • Sprint:
      Moodle 3.9 - Moppies Kanban

      Description

      See the screenshot attached. It happened with an Essay H5P activity.

      This happens only when formatstringstriptags is disabled

        Attachments

        1. 68902-all.png
          68902-all.png
          884 kB
        2. essay-4-166755.h5p
          683 kB
        3. filltheblanks.h5p
          699 kB
        4. modified_reports_option_b.png
          modified_reports_option_b.png
          159 kB
        5. Screenshot 2020-06-03 at 10.28.27.png
          Screenshot 2020-06-03 at 10.28.27.png
          154 kB
        6. testoutput.php
          1 kB

          Issue Links

            Activity

              People

              Assignee:
              tusefomal Ferran Recio
              Reporter:
              dpalou Dani Palou
              Peer reviewer:
              Carlos Escobedo
              Integrator:
              Sara Arjona (@sarjona)
              Tester:
              CiBoT
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Jun/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 days, 6 hours, 49 minutes
                  2d 6h 49m