Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68912

"Send a message" not working when selecting all participants

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.9
    • Fix Version/s: 3.9
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide
      Prerequisite
      1. Outgoing email setup (e.g. using mailcatcher)
      Test
      1. Login as a teacher and go to the Participants page for a course and enroll some additional participants
      2. Select all the participants either by clicking on the checkboxes for all the users or selecting select-all-participants checkbox
      3. In "With selected users." dropdown choose "Send a message"
      4. Verify that the popup says "Send message to X people" where X is the number of participants in the course
      5. Should try using other options in "With selected users" combined with the selecting all participants and verify they work as well.
      Show
      Prerequisite Outgoing email setup (e.g. using mailcatcher) Test Login as a teacher and go to the Participants page for a course and enroll some additional participants Select all the participants either by clicking on the checkboxes for all the users or selecting select-all-participants checkbox In "With selected users." dropdown choose "Send a message" Verify that the popup says "Send message to X people" where X is the number of participants in the course Should try using other options in "With selected users" combined with the selecting all participants and verify they work as well.
    • Affected Branches:
      MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_39_STABLE
    • Pull Master Branch:

      Description

      1. Login as a teacher and go to the Participants page for a course like https://qa.moodledemo.net/user/index.php?id=2
      2. Select all the participants either by clicking on the checkboxes for all the users or selecting select-all-participants checkbox
      3. On the QA server that would select 3 users
      4. In "With selected users." dropdown choose "Send a message"
      5. See that the popup says "Send message to 4 people" instead of the expected "Send message to 3 people".
      6. Also, when I click on submit, I never seem to get the success message. So unsure if messages were actually sent.

      The error seems like it is counting the select-all-participants checkbox in the number of users, because if you unselect one user it says "Send message to 2 people" and I do see a success message

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              rex Rex Lorenzo
              Reporter:
              rex Rex Lorenzo
              Peer reviewer:
              Andrew Lyons Andrew Lyons
              Integrator:
              Jun Pataleta Jun Pataleta
              Tester:
              Janelle Barcega Janelle Barcega
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Jun/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 40 minutes
                  40m