Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68921

H5P content type Accordion: extra Title field in H5P editor

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 3.9
    • 3.9.2
    • H5P
    • MOODLE_39_STABLE
    • MOODLE_39_STABLE
    • MDL-68921-master
    • Hide

      Test 1 - Upgrading existing library

      Before installing the patch:

      1. Login as admin.
      2. Go to 'Content bank' (in the drawer for Boost theme, in Navigation block > Site pages for Classic theme).
      3. Click on 'Upload' button.
      4. Upload attached accordion.h5p file and 'Save changes'.
      5. Edit the content.
      6. Verify that there are two "Title" fields in each panel ("Cherries", "Cranberries", "Blackberries" and "Açaí berries").

      Test

      1. Apply the patch.
      2. Go to Site Administration.
      3. Upgrade Moodle version.
      4. Go to 'Content bank' (in the drawer for Boost theme, in Navigation block > Site pages for Classic theme).
      5. Double click on the "accordion.h5p" content.
      6. Edit the content.
      7. Confirm there is only a "Title" field in each panel.
      8. Confirm there is a "Metadata" icon next to the "Text" field in each panel.

      Test 2 - Installing a new library

      Prerequisites

      The H5P.AdvanceText library should not be installed before the test.

      1. Login as admin.
      2. Go to Site administration > H5P > Manage H5P content types.
      3. Click on "Installed H5P libraries" tab.
      4. Verify there is no row with the value "Text" under Description.
      5. If it exists, click on the "Trash" icon in the same row.

      Test

      1. Login as admin.
      2. Go to 'Content bank' (in the drawer for Boost theme, in Navigation block > Site pages for Classic theme).
      3. Click on 'Upload' button.
      4. Upload accordion.h5p file and 'Save changes'.
      5. Edit the content.
      6. Confirm there is only a "Title" field in each panel.
      7. Confirm there is a "Metadata" icon next to the "Text" field in each panel.
      Show
      Test 1 - Upgrading existing library Before installing the patch: Login as admin. Go to 'Content bank' (in the drawer for Boost theme, in Navigation block > Site pages for Classic theme). Click on 'Upload' button. Upload attached accordion.h5p file and 'Save changes'. Edit the content. Verify  that there are two "Title" fields in each panel ("Cherries", "Cranberries", "Blackberries" and "Açaí berries"). Test Apply the patch. Go to Site Administration. Upgrade Moodle version. Go to 'Content bank' (in the drawer for Boost theme, in Navigation block > Site pages for Classic theme). Double click on the "accordion.h5p" content. Edit the content. Confirm there is only a "Title" field in each panel. Confirm there is a "Metadata" icon next to the "Text" field in each panel. Test 2 - Installing a new library Prerequisites The H5P.AdvanceText library should not be installed before the test. Login as admin. Go to Site administration > H5P > Manage H5P content types . Click on "Installed H5P libraries" tab. Verify there is no row with the value "Text" under Description. If it exists, click on the "Trash" icon in the same row. Test Login as admin. Go to 'Content bank' (in the drawer for Boost theme, in Navigation block > Site pages for Classic theme). Click on 'Upload' button. Upload accordion.h5p file and 'Save changes'. Edit the content. Confirm there is only a "Title" field in each panel. Confirm there is a "Metadata" icon next to the "Text" field in each panel.
    • Moppies Kanban

    Description

      The Accordion H5P content type shows an extra "Title" field in each Panel item. See the attached screenshot.

      Attachments

        1. accordion.h5p
          530 kB
        2. image-2020-06-04-16-59-54-819.png
          image-2020-06-04-16-59-54-819.png
          82 kB
        3. MDL-68921-310-test1.png
          MDL-68921-310-test1.png
          19 kB
        4. MDL-68921-310-test1-before.png
          MDL-68921-310-test1-before.png
          15 kB
        5. MDL-68921-310-test2.png
          MDL-68921-310-test2.png
          18 kB
        6. MDL-68921-310-test2-prereq.png
          MDL-68921-310-test2-prereq.png
          12 kB
        7. MDL-68921-39-test1.png
          MDL-68921-39-test1.png
          18 kB
        8. MDL-68921-39-test1-before.png
          MDL-68921-39-test1-before.png
          21 kB
        9. MDL-68921-39-test2.png
          MDL-68921-39-test2.png
          19 kB
        10. MDL-68921-39-test2-prereq.png
          MDL-68921-39-test2-prereq.png
          13 kB
        11. MDL-68921-master-test1.png
          MDL-68921-master-test1.png
          9 kB
        12. MDL-68921-master-test1-before.png
          MDL-68921-master-test1-before.png
          21 kB
        13. MDL-68921-master-test2.png
          MDL-68921-master-test2.png
          16 kB
        14. MDL-68921-master-test2-prereq.png
          MDL-68921-master-test2-prereq.png
          13 kB

        Activity

          People

            vmdef Victor Déniz Falcón
            vmdef Victor Déniz Falcón
            Carlos Escobedo Carlos Escobedo
            Adrian Greeve Adrian Greeve
            Michael Hawkins Michael Hawkins
            Amaia Anabitarte, Bas Brands, Carlos Escobedo, Laurent David, Sabina Abellan, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              14/Sep/20

              Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 days, 30 minutes
                2d 30m