Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68922

H5P doesn't upgrade content when there is a newer H5P library

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.9
    • Fix Version/s: 3.9
    • Component/s: H5P
    • Testing Instructions:
      Hide
      1. Login as admin.
      2. Go to "Site administration /  H5P / Manage H5P content types".
      3. Upload the library course-presentationv1.22.h5p (you'll find it attached to this issue).
      4. Access to the content bank.
      5. Upload the file course-presentationv1.20.h5p
      6. Edit this file.
      7. Change the title and some visible content (such as "Cloudberries" to "Cloudberries MODIFIED", double-clicking over it).
      8. Save changes.
      9. Check the content is saved and the H5P has the changes done in #7.
      Show
      Login as admin. Go to "Site administration /  H5P / Manage H5P content types". Upload the library course-presentationv1.22.h5p (you'll find it attached to this issue). Access to the content bank. Upload the file course-presentationv1.20.h5p Edit this file. Change the title and some visible content (such as "Cloudberries" to "Cloudberries MODIFIED", double-clicking over it). Save changes. Check the content is saved and the H5P has the changes done in #7.
    • Affected Branches:
      MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_39_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-68922-master
    • Sprint:
      Moodle 3.9 - Moppies Kanban

      Description

      Steps to reproduce:

      1. Go to "Site administration /  H5P / Manage H5P content types".
      2. Upload the library course-presentationv1.22.h5p (you'll find it attached to this issue)
      3. Access to the content bank.
      4. Upload the file course-presentationv1.20.h5p
      5. Edit this file.
      6. Edit the title or any content.
      7. Save changes.

      Expected behaviour:

      The content is saved and the content uses the latest Course presentation library (1.22).

       

      Current behaviour:

      There is an error:

      • If the patch in MDL-68917 is applied (or it has been integrated), the error is: Coding error detected, it must be fixed by a programmer: Wrong H5P library.
      • Without this patch, the editor is not saving anything and an error is displayed in JS console saying that, at least, a couple of files (h5p-version.js and h5p-content-upgrade-process.js can't be found).

        Attachments

        1. course-presentationv1.19.h5p
          2.88 MB
        2. course-presentationv1.20.h5p
          4.14 MB
        3. course-presentationv1.22.h5p
          4.47 MB
        4. course-presentationv1.8.h5p
          15.56 MB
        5. edit_h5p.png
          edit_h5p.png
          509 kB
        6. image-2020-06-08-10-30-12-994.png
          image-2020-06-08-10-30-12-994.png
          608 kB

          Issue Links

            Activity

              People

              Assignee:
              sarjona Sara Arjona (@sarjona)
              Reporter:
              sarjona Sara Arjona (@sarjona)
              Peer reviewer:
              Carlos Escobedo
              Integrator:
              Adrian Greeve
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Jun/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 hours, 50 minutes
                  5h 50m