-
Improvement
-
Resolution: Fixed
-
Minor
-
3.9, 3.10, 4.0
-
MOODLE_310_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
-
MOODLE_310_STABLE
-
-
5
-
4.0 holding pattern 4
As mentioned by Jun during his review of MDL-67883 we add a way to allow site admins to decide what will be displayed in the activity chooser footer with the default set to MoodleNet.
This will help in the case another plugin implements the required callback and wins the race against MoodleNet.
See below for context:
\core_course_external::get_activity_chooser_footer()
- I'm not sure whether we should be limiting the execution of other plugins implementing the "_custom_chooser_footer" hook. If another plugin implements this function, but we still want to display the link to MoodleNet, if the call to "\get_plugins_with_function()" runs the other plugin's implementation first, then the MoodleNet link won't be shown anymore. Perhaps we should remove the breaks in the loop and either do the following:
- Allow the activity chooser footer to be able to display multiple activity_chooser_footer items from plugins.
- Add an admin setting that allows the admin to select which `activity_chooser_footer` item should be displayed in the activity chooser footer. This would provide reliability on the item will be displayed in the activity chooser footer as opposed to the first-processed, first-displayed nature of the current implementation.
Let me know your thoughts. In any case, this can be done as a separate issue/follow up.
