Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68933

Feedback link in the footer should be cached

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.9
    • Fix Version/s: 3.9
    • Component/s: General
    • Labels:
    • Affected Branches:
      MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_39_STABLE
    • Pull Master Branch:
      MDL-68933-master
    • Testing Instructions:
      Hide
      Before patch:
      1. Make sure "Administration / Feedback settings > enableuserfeedback" is turned on.
      2. Enable developer mode.
        • On MDK: "mdk run mindev"
      3. Go to the Dashboard page.
      4. On the footer, take note of the following values:
        • RAM
        • Included files
      5. Hover over the "Give feedback" and take note of the value of the "theme_version" parameter.
      After patch
      1. With the patch applied, reload the page.
      2. Confirm that the RAM and Included files values have decreased.
      3. Confirm that the "theme_version" remains the same.
      Show
      Before patch: Make sure " Administration / Feedback settings > enableuserfeedback " is turned on. Enable developer mode. On MDK: " mdk run mindev " Go to the Dashboard page. On the footer, take note of the following values: RAM Included files Hover over the " Give feedback " and take note of the value of the " theme_version " parameter. After patch With the patch applied, reload the page. Confirm that the RAM and Included files values have decreased. Confirm that the " theme_version " remains the same.

      Description

      Looking at the performance runs it seems that MDL-68076 caused a memory increment 4,8% worse: https://performance.stronk7.com/?timestamps%5B%5D=1591248856745&timestamps%5B%5D=1591247673920&n=1

      This content should be cached in order to improve performance.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jpataleta Jun Pataleta
              Reporter:
              sarjona Sara Arjona (@sarjona)
              Peer reviewer:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Integrator:
              Sara Arjona (@sarjona) Sara Arjona (@sarjona)
              Tester:
              Sara Arjona (@sarjona) Sara Arjona (@sarjona)
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Jun/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 25 minutes
                  1h 25m