Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68933

Feedback link in the footer should be cached

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.9
    • 3.9
    • General
    • MOODLE_39_STABLE
    • MOODLE_39_STABLE
    • MDL-68933-master
    • Hide
      Before patch:
      1. Make sure "Administration / Feedback settings > enableuserfeedback" is turned on.
      2. Enable developer mode.
        • On MDK: "mdk run mindev"
      3. Go to the Dashboard page.
      4. On the footer, take note of the following values:
        • RAM
        • Included files
      5. Hover over the "Give feedback" and take note of the value of the "theme_version" parameter.
      After patch
      1. With the patch applied, reload the page.
      2. Confirm that the RAM and Included files values have decreased.
      3. Confirm that the "theme_version" remains the same.
      Show
      Before patch: Make sure " Administration / Feedback settings > enableuserfeedback " is turned on. Enable developer mode. On MDK: " mdk run mindev " Go to the Dashboard page. On the footer, take note of the following values: RAM Included files Hover over the " Give feedback " and take note of the value of the " theme_version " parameter. After patch With the patch applied, reload the page. Confirm that the RAM and Included files values have decreased. Confirm that the " theme_version " remains the same.

      Looking at the performance runs it seems that MDL-68076 caused a memory increment 4,8% worse: https://performance.stronk7.com/?timestamps%5B%5D=1591248856745&timestamps%5B%5D=1591247673920&n=1

      This content should be cached in order to improve performance.

            jpataleta Jun Pataleta
            sarjona Sara Arjona (@sarjona)
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 25 minutes
                1h 25m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.