Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.6, 1.6.1, 1.6.2, 1.6.3, 1.7
    • Fix Version/s: 1.7
    • Component/s: Gradebook
    • Labels:
      None
    • Database:
      MySQL
    • Affected Branches:
      MOODLE_16_STABLE, MOODLE_17_STABLE
    • Fixed Branches:
      MOODLE_17_STABLE
    • Rank:
      28012

      Description

      When using the gradebook to select grades by group with the dropdown box, the error message is given:

      No category to view by

      This is because the drop down box will generate a url like this: /grade/index.php?id=7&action=vcats&cview=&group=1

      Which doesn't have the vcat.

      From what I can see thisis because grade_download_form uses the global variable $cview in creating its groups menu ($url sent to setup_and_print_groups).

      When grade_view_all_grades is called on line 75 of grades/index.php, this global variable is not set.

      Ideally refactoring all of this code to get rid of such externsive use of the global $cview variable would seem like the best solution, but this resolves it in the interim.

        Activity

        Hide
        Dan Poltawski added a comment -

        Sorry, I meant to say it doesn't have the cview

        Show
        Dan Poltawski added a comment - Sorry, I meant to say it doesn't have the cview
        Hide
        Dan Poltawski added a comment -

        For reference, there is a forum topic which discusses the issue: http://moodle.org/mod/forum/discuss.php?d=53405

        Show
        Dan Poltawski added a comment - For reference, there is a forum topic which discusses the issue: http://moodle.org/mod/forum/discuss.php?d=53405
        Hide
        Martin Dougiamas added a comment -

        Yu, can you apply this please?

        Show
        Martin Dougiamas added a comment - Yu, can you apply this please?
        Hide
        Yu Zhang added a comment -

        Hi,

        Thanks for the patch, fixed in HEAD and 1.7

        Show
        Yu Zhang added a comment - Hi, Thanks for the patch, fixed in HEAD and 1.7
        Hide
        Ken Wilson added a comment -

        Confirmed OK in testing. Tested by: click assignment name -> view assignment. Choose group from Separate Groups drop-down box. Students listed with data changed as expected. Thank-you. Now closed.

        Show
        Ken Wilson added a comment - Confirmed OK in testing. Tested by: click assignment name -> view assignment. Choose group from Separate Groups drop-down box. Students listed with data changed as expected. Thank-you. Now closed.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: