Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68984

First/last name filtering uses filterset join type instead of always being applied

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.9
    • Fix Version/s: 3.9
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide

      Setup

      1. Have a course with at least 10 users, including the following (if you are using an existing course, you can just rename existing users):
        First name Surname Role Status
        Jeff Hawkins teacher Active
        Jeff Hanneman student Active
        John Dorian student Active
        Jacob Kennedy student Suspended
      2. Note: Make sure no other users in the course have a first name beginning with "J".

      Testing

      1. Log in as a teacher in the course.
      2. Navigate to the course participants page.
      3. CONFIRM you see all enrolled users, including the four users mentioned in setup.
      4. Click on "J" in the "First name" filter.
      5. CONFIRM you now only see the four users beginning with 'J' mentioned in setup in the participants list.
      6. Apply the following participants filters:
        Match Type Value
        Any Status Active
        Any Role Student
      7. Make sure the match type at the top of the filters section is set to "Match ANY of the following".
      8. Press "Apply filters".
      9. CONFIRM you still only see the four users listed in setup in the participants table.
      10. Update the filterset match type to "Match ALL of the following".
      11. Press "Apply filters".
      12. CONFIRM you now only see Jeff Hanneman and John Dorian in the participants list (no other users).
      13. Click on "H" in the "Surname" filter.
      14. CONFIRM Jeff Hanneman is now the only user displayed in the participants list.
      Show
      Setup Have a course with at least 10 users, including the following (if you are using an existing course, you can just rename existing users): First name Surname Role Status Jeff Hawkins teacher Active Jeff Hanneman student Active John Dorian student Active Jacob Kennedy student Suspended Note: Make sure no other users in the course have a first name beginning with "J". Testing Log in as a teacher in the course. Navigate to the course participants page. CONFIRM you see all enrolled users, including the four users mentioned in setup. Click on "J" in the "First name" filter. CONFIRM you now only see the four users beginning with 'J' mentioned in setup in the participants list. Apply the following participants filters: Match Type Value Any Status Active Any Role Student Make sure the match type at the top of the filters section is set to "Match ANY of the following". Press "Apply filters". CONFIRM you still only see the four users listed in setup in the participants table. Update the filterset match type to "Match ALL of the following". Press "Apply filters". CONFIRM you now only see Jeff Hanneman and John Dorian in the participants list (no other users). Click on "H" in the "Surname" filter. CONFIRM Jeff Hanneman is now the only user displayed in the participants list.
    • Affected Branches:
      MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_39_STABLE
    • Pull Master Branch:
      MDL-68984-master

      Description

      Firstname / surname filters should always be applied (logical AND), but are currently using the filterset join type. For example, if a single filter is being applied (which defaults to logical OR), the participants list will include the filter OR the name filtering, instead of both.

        Attachments

          Activity

            People

            Assignee:
            michaelh Michael Hawkins
            Reporter:
            michaelh Michael Hawkins
            Peer reviewer:
            Mathew May
            Integrator:
            Víctor Déniz Falcón
            Tester:
            Anna Carissa Sadia
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              15/Jun/20

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 hours, 5 minutes
                4h 5m