Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68989

Keyword participants filter innacurate for filterset None match type

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.9
    • Fix Version/s: 3.9
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide

      Setup

      1. Have a course with at least 10 users, including the following (if you are using an existing course, you can just rename existing users):
        First name Surname Role Status
        Jeff Hawkins teacher Active
        Jeff Hanneman student Active
      2. Note: You should have no other uses with Jeff in their name/email etc.

      Testing

      1. Log in as a teacher in the course.
      2. Navigate to the course participants page.
      3. CONFIRM you see all enrolled users, including the four users mentioned in setup.
      4. Apply the following participants filter:
        Match Type Value
        Any Keyword Jeff
      5. Press "Apply filters".
      6. CONFIRM You now only see the two Jeffs mentioned in setup and no other users.
      7. Click the "Add condition" button (you won't fill in the second filter yet).
      8. Update the filterset match type to "Match NONE of the following".
      9. Press "Apply filters".
      10. CONFIRM you no longer see either Jeff in the participants list, but see all other users.
      11. Apply the following values to the second filter:
        Match Type Value
        Any Role Teacher
      12. Press "Apply filters".
      13. CONFIRM you now only see student users in the participants list, and do not see either of the two Jeffs.
      14. Update both of the filter rows to match "None" and press "Apply filters".
      15. CONFIRM you now only see Jeff Hawkins in the participants list and no other users.
      Show
      Setup Have a course with at least 10 users, including the following (if you are using an existing course, you can just rename existing users): First name Surname Role Status Jeff Hawkins teacher Active Jeff Hanneman student Active Note: You should have no other uses with Jeff in their name/email etc. Testing Log in as a teacher in the course. Navigate to the course participants page. CONFIRM you see all enrolled users, including the four users mentioned in setup. Apply the following participants filter: Match Type Value Any Keyword Jeff Press "Apply filters". CONFIRM You now only see the two Jeffs mentioned in setup and no other users. Click the "Add condition" button (you won't fill in the second filter yet). Update the filterset match type to "Match NONE of the following". Press "Apply filters". CONFIRM you no longer see either Jeff in the participants list, but see all other users. Apply the following values to the second filter: Match Type Value Any Role Teacher Press "Apply filters". CONFIRM you now only see student users in the participants list, and do not see either of the two Jeffs. Update both of the filter rows to match "None" and press "Apply filters". CONFIRM you now only see Jeff Hawkins in the participants list and no other users.
    • Affected Branches:
      MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_39_STABLE
    • Pull Master Branch:
      MDL-68989-master

      Description

      The keywords participants filter correctly handles the None match type within the filter row by checking 'not null' in the SQL query, but also needs to do the same when the filterset is set to match None.

        Attachments

          Activity

            People

            Assignee:
            michaelh Michael Hawkins
            Reporter:
            michaelh Michael Hawkins
            Peer reviewer:
            Simey Lameze
            Integrator:
            Jun Pataleta
            Tester:
            Anna Carissa Sadia
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              15/Jun/20

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 5 hours, 38 minutes
                5h 38m