Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69005

Cache performance footer created PHP notice accessing private property

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 3.9
    • 3.9
    • Caching

    Description

      When logging into a 3.9 site, I'm seeing the following notice flash up during login:

      <b>Notice</b>:  Undefined property: cache_session::$store in <b>/opt/workplace/master-1427/src/cache/classes/loaders.php</b> on line <b>2100</b><br />
      

      Looking at web server logs:

      [Wed Jun 10 09:01:36.228082 2020] [php7:notice] [pid 1312] [client 192.168.122.1:41710] PHP Notice:  Undefined property: cache_session::$store in /opt/workplace/master-1427/src/cache/classes/loaders.php on line 2100, referer: http://workplace.internal/master-1427/login/index.php
      [Wed Jun 10 09:05:32.406005 2020] [php7:notice] [pid 1371] [client 192.168.122.1:41774] PHP Notice:  Undefined property: cache_session::$store in /opt/workplace/master-1427/src/cache/classes/loaders.php on line 2100, referer: http://workplace.internal/master-1427/login/index.php
      [Wed Jun 10 09:05:54.504573 2020] [php7:notice] [pid 1365] [client 192.168.122.1:41786] PHP Notice:  Undefined property: cache_session::$store in /opt/workplace/master-1427/src/cache/classes/loaders.php on line 2100, referer: http://workplace.internal/master-1427/login/index.php
      [Wed Jun 10 09:06:02.532044 2020] [php7:notice] [pid 1365] [client 192.168.122.1:41786] PHP Notice:  Undefined property: cache_session::$store in /opt/workplace/master-1427/src/cache/classes/loaders.php on line 2100, referer: http://workplace.internal/master-1427/login/index.php
      [Wed Jun 10 09:07:55.372056 2020] [php7:notice] [pid 1311] [client 192.168.122.1:41914] PHP Notice:  Undefined property: cache_session::$store in /opt/workplace/master-1427/src/cache/classes/loaders.php on line 2100, referer: http://workplace.internal/master-1427/login/index.php
      [Wed Jun 10 09:10:50.035811 2020] [php7:notice] [pid 1372] [client 192.168.122.1:41960] PHP Notice:  Undefined property: cache_session::$store in /opt/workplace/master-1427/src/cache/classes/loaders.php on line 2100, referer: http://workplace.internal/master-1427/login/index.php
      

      Seems to be caused by this line from MDL-68329: https://github.com/moodle/moodle/commit/9f4bb48e40c4bf267b7db3bd1615fb31af5d6828#diff-8ed1f23b27be1c3c6ccd606270576828R2100 ($this->store is a private property of the parent class)

      Attachments

        Issue Links

          Activity

            People

              pholden Paul Holden
              pholden Paul Holden
              Marina Glancy Marina Glancy
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              CiBoT CiBoT
              Matteo Scaramuccia, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                15/Jun/20

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 51 minutes
                  51m