[MDL-69005] Cache performance footer created PHP notice accessing private property - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.9
Fix Version/s: 3.9
Component/s: Caching
Labels:
- ci

Affected Branches:
MOODLE_39_STABLE
Fixed Branches:
MOODLE_39_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull Master Branch:
~~MDL-69005~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-69005
Testing Instructions:
Hide

Run unit tests

$ vendor/bin/phpunit cache/tests/cache_test.php
Show
Run unit tests $ vendor/bin/phpunit cache/tests/cache_test.php

Description

When logging into a 3.9 site, I'm seeing the following notice flash up during login:

<b>Notice</b>:  Undefined property: cache_session::$store in <b>/opt/workplace/master-1427/src/cache/classes/loaders.php</b> on line <b>2100</b><br />

Looking at web server logs:

[Wed Jun 10 09:01:36.228082 2020] [php7:notice] [pid 1312] [client 192.168.122.1:41710] PHP Notice:  Undefined property: cache_session::$store in /opt/workplace/master-1427/src/cache/classes/loaders.php on line 2100, referer: http://workplace.internal/master-1427/login/index.php

[Wed Jun 10 09:05:32.406005 2020] [php7:notice] [pid 1371] [client 192.168.122.1:41774] PHP Notice:  Undefined property: cache_session::$store in /opt/workplace/master-1427/src/cache/classes/loaders.php on line 2100, referer: http://workplace.internal/master-1427/login/index.php

[Wed Jun 10 09:05:54.504573 2020] [php7:notice] [pid 1365] [client 192.168.122.1:41786] PHP Notice:  Undefined property: cache_session::$store in /opt/workplace/master-1427/src/cache/classes/loaders.php on line 2100, referer: http://workplace.internal/master-1427/login/index.php

[Wed Jun 10 09:06:02.532044 2020] [php7:notice] [pid 1365] [client 192.168.122.1:41786] PHP Notice:  Undefined property: cache_session::$store in /opt/workplace/master-1427/src/cache/classes/loaders.php on line 2100, referer: http://workplace.internal/master-1427/login/index.php

[Wed Jun 10 09:07:55.372056 2020] [php7:notice] [pid 1311] [client 192.168.122.1:41914] PHP Notice:  Undefined property: cache_session::$store in /opt/workplace/master-1427/src/cache/classes/loaders.php on line 2100, referer: http://workplace.internal/master-1427/login/index.php

[Wed Jun 10 09:10:50.035811 2020] [php7:notice] [pid 1372] [client 192.168.122.1:41960] PHP Notice:  Undefined property: cache_session::$store in /opt/workplace/master-1427/src/cache/classes/loaders.php on line 2100, referer: http://workplace.internal/master-1427/login/index.php

Seems to be caused by this line from ~~MDL-68329~~: https://github.com/moodle/moodle/commit/9f4bb48e40c4bf267b7db3bd1615fb31af5d6828#diff-8ed1f23b27be1c3c6ccd606270576828R2100 ($this->store is a private property of the parent class)

Attachments

Issue Links

has a non-specific relationship to

MDL-66322 Use exttests repo in travis

Closed

is a regression caused by

MDL-68329 Improve the cache performance footer info even more

Closed

Activity

People

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Marina Glancy

Integrator:: Eloy Lafuente (stronk7)

Tester:: CiBoT

Participants:: Andrew Lyons, CiBoT, Eloy Lafuente (stronk7), Marina Glancy, Matteo Scaramuccia, Paul Holden, Sara Arjona (@sarjona)

Component watchers:: Matteo Scaramuccia, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 10/Jun/20 4:32 PM

Updated:: 12/Jun/20 12:41 AM

Resolved:: 12/Jun/20 12:41 AM

Fix Release Date:: 15/Jun/20

Time Tracking

Estimated:

Remaining:

Logged:

51m