-
Bug
-
Resolution: Fixed
-
Minor
-
3.5.12, 3.7.6, 3.8.3, 3.9.1, 3.10, 4.0
-
MOODLE_310_STABLE, MOODLE_35_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
-
MOODLE_38_STABLE, MOODLE_39_STABLE
-
Prior to change (before patch)
- Navigate to Appearance > User tours in site administration
- Press Import tour
- Upload tour_export_2_1595343697.json
and press Save changes - Navigate back to Appearance > User tours
- Enable the tour you imported
- Navigate to Dashboard
- Confirm new tour starts, press End tour
- Navigate back to Appearance > User tours
- Delete the tour you imported
- In your database terminal confirm the user preference exists for the tour:
SELECT * FROM mdl_user_preferences WHERE name LIKE 'tool_usertours%'
Checkout
MDL-69014branch (switch to after patch)- Run upgrade
- In your database terminal confirm the absence of user preferences for the deleted tour:
SELECT * FROM mdl_user_preferences WHERE name LIKE 'tool_usertours%'
Confirm preferences are now deleted with the tour
- Re-upload, and enable, the tour_export_2_1595343697.json tour
- Navigate to Dashboard
- Confirm new tour starts, press End tour
- In your database terminal confirm the user preference exists for the tour:
SELECT * FROM mdl_user_preferences WHERE name LIKE 'tool_usertours%' - Navigate back to Appearance > User tours
- Delete the tour you imported
- In your database terminal confirm the absence of user preferences for the deleted tour:
SELECT * FROM mdl_user_preferences WHERE name LIKE 'tool_usertours%'
Prior to change (before patch) Navigate to Appearance > User tours in site administration Press Import tour Upload tour_export_2_1595343697.json and press Save changes Navigate back to Appearance > User tours Enable the tour you imported Navigate to Dashboard Confirm new tour starts, press End tour Navigate back to Appearance > User tours Delete the tour you imported In your database terminal confirm the user preference exists for the tour: SELECT * FROM mdl_user_preferences WHERE name LIKE 'tool_usertours%' Checkout MDL-69014 branch (switch to after patch) Run upgrade In your database terminal confirm the absence of user preferences for the deleted tour: SELECT * FROM mdl_user_preferences WHERE name LIKE 'tool_usertours%' Confirm preferences are now deleted with the tour Re-upload, and enable, the tour_export_2_1595343697.json tour Navigate to Dashboard Confirm new tour starts, press End tour In your database terminal confirm the user preference exists for the tour: SELECT * FROM mdl_user_preferences WHERE name LIKE 'tool_usertours%' Navigate back to Appearance > User tours Delete the tour you imported In your database terminal confirm the absence of user preferences for the deleted tour: SELECT * FROM mdl_user_preferences WHERE name LIKE 'tool_usertours%'
User tours store a couple of user preferences for each tour:
- the last time that the user completed the tour
- the last time that the user specifically re-requested the tour
It seems that we do not remove these preferences when a user deletes a tour. We should.
