Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69036

Hovering over rows with dimmed_text darkens the row inconsistently

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Link colours in table

      1. Login as admin
      2. Navigate to Plugins > Filters > Manage filters in site administration
      3. Hover over the row of any of the disabled filters
      4. Confirm the row text darkens
      5. Confirm the row Settings and/or Uninstall links show as black (no longer dimmed)

      Action menu links in tables (Jake's regression)

      1. Create a new user "Lionel Christmas"
      2. Navigate to Users > Privacy and policies > Data requests in site administration
      3. Press New request
      4. Select the user you just created and "Export all of my personal data"
      5. Press Save changes
      6. When viewing the Data requests table, click the Actions menu for the request you just created
      7. Confirm that each item in the action menu is readable/unaffected by this change
      Show
      Link colours in table Login as admin Navigate to Plugins > Filters > Manage filters in site administration Hover over the row of any of the disabled filters Confirm the row text darkens Confirm the row Settings and/or Uninstall links show as black (no longer dimmed) Action menu links in tables (Jake's regression) Create a new user "Lionel Christmas" Navigate to Users > Privacy and policies > Data requests in site administration Press New request Select the user you just created and "Export all of my personal data" Press Save changes When viewing the Data requests table, click the Actions menu for the request you just created Confirm that each item in the action menu is readable/unaffected by this change
    • Fixed Branches:
      MOODLE_310_STABLE, MOODLE_39_STABLE
    • Pull 3.9 Branch:
    • Pull 3.10 Branch:
      MDL-69036-310
    • Pull 3.11 Branch:
      MDL-69036-311
    • Pull Master Branch:

      Description

      When hovering over a table row with dimmed_text class (to indicate enabled/disabled toggle, e.g. Adminsitration>Plugins>Filters>Manage filters) the row darkens, but this isn't done consistently (the whole row, text and links, should remain dimmed or darken together).

      Moodle 3.9 - "Word censorship" changes font color when hovering ("Settings" and "Uninstall" links do not).

      Moodle 3.8 - "Word censorship" remains dimmed when hovering.

        Attachments

        1. before.png
          466 kB
          Bas Brands
        2. data_export_problem.png
          34 kB
          Jake Dallimore
        3. dimmed_text.jpg
          52 kB
          Paul Holden
        4. image-2020-12-10-11-38-34-084.png
          17 kB
          Janelle Barcega
        5. image-2021-03-24-10-50-44-929.png
          153 kB
          Janelle Barcega
        6. MDL69036-1.png
          25 kB
          Mikel Martín Corrales
        7. MDL69036-2.png
          25 kB
          Mikel Martín Corrales
        8. WIlvT.png
          25 kB
          Bas Brands

          Issue Links

            Activity

              People

              Assignee:
              pholden Paul Holden
              Reporter:
              pholden Paul Holden
              Peer reviewer:
              Mikel Martín Corrales Mikel Martín Corrales
              Integrator:
              Andrew Lyons Andrew Lyons
              Tester:
              Janelle Barcega Janelle Barcega
              Participants:
              Component watchers:
              Amy Groshek, David Scotson, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                25/Mar/21

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours, 25 minutes
                  4h 25m