Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69051

Have unit tests cover install.xml file permissions

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Waiting for peer review
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.9
    • Fix Version/s: None
    • Component/s: Unit tests

      Description

      We have many moodle plugins which pass CI, but when installed in totara throw unit test error eg this:

      https://github.com/catalyst/moodle-local_csp/issues/46

      Totara is doing some extra assertions to make sure that the file is written correctly which are a good thing to do and moodle should probably do them too.

      Sam Hemelryk is this something we could ask for permission to cherry pick over? This should be in Totara's interests so that more Moodle plugins in the wild are more easily compatible with Totara and don't explode when installed.

       

        Attachments

          Activity

            People

            Assignee:
            samhemelryk Sam Hemelryk
            Reporter:
            brendanheywood Brendan Heywood
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated: