[MDL-69061] Lack of files reported during upgrade to 3.9 when $CFG->admin differs from 'admin' - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.8 regressions, 3.9
Fix Version/s: 3.9.12, 3.10.9, 3.11.5
Component/s: Administration
Labels:
- ci
- release_notes

Database:

PostgreSQL
Affected Branches:
MOODLE_39_STABLE
Fixed Branches:
MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE
Pull from Repository:
https://github.com/junpataleta/moodle.git
Pull 3.9 Branch:
~~MDL-69061~~-39
Pull 3.9 Diff URL:
https://github.com/junpataleta/moodle/compare/504f784ae6...MDL-69061-39
Pull 3.11 Branch:
~~MDL-69061~~-311
Pull 3.11 Diff URL:
https://github.com/junpataleta/moodle/compare/d6688ad206...MDL-69061-311
Pull Main Branch:
~~MDL-69061~~-master
Pull Main Diff URL:
https://github.com/junpataleta/moodle/compare/0c63990e4f...MDL-69061-master
Difficulty:
Easy
Testing Instructions:
Hide

Check out Moodle 3.7

git checkout MOODLE_37_STABLE

Install the instance. (eg. if using MDK, "mdk install")

Check out the branch you're testing. e.g. in Moodle 3.9 "git checkout MOODLE_39_STABLE"

Rename 'admin' directory to 'customadmin'

In config.php set "$CFG->admin = 'customadmin';"

Login as admin

Start the upgrade

On the list of plugins page, confirm that there are no "Missing from disk" errors, especially from the admin tools.

Perform the upgrade.

Confirm that the upgrade completes successfully.
Show
Check out Moodle 3.7 git checkout MOODLE_37_STABLE Install the instance. (eg. if using MDK, " mdk install ") Check out the branch you're testing. e.g. in Moodle 3.9 " git checkout MOODLE_39_STABLE " Rename 'admin' directory to 'customadmin' In config.php set " $CFG->admin = 'customadmin'; " Login as admin Start the upgrade On the list of plugins page, confirm that there are no " Missing from disk " errors, especially from the admin tools. Perform the upgrade. Confirm that the upgrade completes successfully.

Description

Lack of files is reported during upgrade to 3.9 when $CFG->admin differs from 'admin'.

After upgrade error Cannot find log manager class '\tool_log\log\manager' is reported.

To reproduce.

Install clean version of Moodle (prior to 3.8)
Remove all files and directories (accept config.php)
Unzip Moodle software version 3.9
Change admin directory name to customadmin
Set $CFG->admin = customadmin in config.php
perform an upgrade

On the list of plugins plenty of plugins reports lack of files.

After upgrade: Cannot find log manager class '\tool_log\log\manager' error is reported

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

37-to-master-upgrade.png
46 kB
11/Jan/22 9:17 PM
MDL-69061_master.png
22 kB
11/Jan/22 8:40 PM
MDL-69061_v310.webm
8.36 MB
11/Jan/22 8:42 PM
MDL-69061_v311.webm
8.33 MB
11/Jan/22 8:42 PM
MDL-69061_v39.webm
7.65 MB
11/Jan/22 8:42 PM

Issue Links

is duplicated by

MDL-72081 $CFG->admin not working due to plugins not being installed properly.

Closed

will help resolve

MDL-67815 Upgrade to 3.8 fails when $CFG->admin renamed

Closed

Activity

People

Assignee:: Adam Pawełczak

Reporter:: Adam Pawełczak

Peer reviewer:: Marina Glancy

Integrator:: Jun Pataleta

Tester:: Angelia Dela Cruz

Participants:: Adam Pawełczak, Angelia Dela Cruz, CiBoT, Eloy Lafuente (stronk7), Jun Pataleta, Leon Stringer, Marina Glancy

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 15/Jun/20 9:58 PM

Updated:: 11/Jan/22 10:58 PM

Resolved:: 11/Jan/22 10:10 PM

Fix Release Date:: 17/Jan/22

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

2h 11m