Details
-
Type:
New Feature
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.9
-
Fix Version/s: 3.10
-
Sprint:Moppies Kanban
Description
When H5P has been added to Moodle 3.9 it has neglected to include the 'hvp_alter_styles' (https://h5p.org/documentation/for-developers/visual-changes and https://h5p.org/node/285646 and https://h5p.org/moodle-customization) functionality that comes with the contributed module (https://moodle.org/plugins/mod_hvp).
This makes it impossible (as you can't use - or at least I've tried - JS to inject custom styles into an 'iframe' within an 'iframe').
So I'm marking this a 'regressional bug' as the core functionality does less than the contributed version.
So, mod_hvp has in 'classes/view_assets.php':
whereas 'h5p/classes/player.php' has:
Therefore a theme cannot override anything i.e. 'mod_hvp's renderer and add additional styles so that its not a mix of Moodle and H5P styles.