[MDL-69110] Sorting does not work anymore in non-dynamic tables - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.9
Fix Version/s: 3.9.1
Component/s: Libraries
Labels:

Affected Branches:
MOODLE_39_STABLE
Fixed Branches:
MOODLE_39_STABLE
Pull from Repository:
git://github.com/junpataleta/moodle.git
Pull 3.9 Branch:
~~MDL-69110~~-39
Pull 3.9 Diff URL:
https://github.com/junpataleta/moodle/compare/89ce4db476...MDL-69110-39
Pull Master Branch:
~~MDL-69110~~-master
Pull Master Diff URL:
https://github.com/junpataleta/moodle/compare/c11e2517a7...MDL-69110-master
Testing Instructions:
Hide

Create an assignment that accepts online text and has "Require students to click the submit button" set to Yes.

Log in using a few student accounts and create an assignment submission. Have some submissions remain in draft.

Log in as a teacher.

View all submissions.

On the assignment grading table, sort the users by column.

Confirm that the users are being sorted correctly according to the selected column and sort order.
Show
Create an assignment that accepts online text and has " Require students to click the submit button " set to Yes. Log in using a few student accounts and create an assignment submission. Have some submissions remain in draft. Log in as a teacher. View all submissions. On the assignment grading table, sort the users by column. Confirm that the users are being sorted correctly according to the selected column and sort order.

Story Points:
2
Sprint:
International 4.0 - Sprint 1

Description

The classical method of sorting the various quiz attempts by clicking on the column link does not work well anymore. The first time you click on the link, attempts are sorted in descending order by the column selected, but subsequent clicks always do the same.

The expected behaviour is to invert the sort order with each click.

Also, the little black arrows indicating the present sort order are not shown anymore.

To reproduce:

Try to view the attempt list of some quiz with attempts. The page is <base URL>mod/quiz/report.php?id=1569&mode=overview (the quiz ID will be different in your case, obviously)

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-69110.png
293 kB
08/Jul/20 3:04 PM

Issue Links

is a regression caused by

MDL-68508 Sort by should support an array of values

Closed

Testing discovered

MDL-69201 Table SQL's primary sort order icon does not render right away

Closed

Activity

People

Assignee:: Jun Pataleta

Reporter:: Orestes Mas

Peer reviewer:: Luca Bösch

Integrator:: Andrew Lyons

Tester:: Anna Carissa Sadia

Participants:: Andrew Lyons, Anna Carissa Sadia, CiBoT, Jun Pataleta, Luca Bösch, Orestes Mas, Tim Hunt

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 22/Jun/20 11:04 PM

Updated:: 11/Jul/20 2:48 AM

Resolved:: 11/Jul/20 2:48 AM

Fix Release Date:: 13/Jul/20

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

3h 51m