Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69112

Underscore in folder name breaks assign feedback multi-upload

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Waiting for integration review
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.8.3, 3.9
    • Fix Version/s: None
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Create a course with 2 students in it.
      2. Add an assignment that has File submissions and Feedback files enabled, and an underscore _ in the assignment name.
      3. As each student, make a file submission.
      4. As a teacher, navigate to the grading page of the assignment.
      5. Make sure that Download submissions in folders is not checked
      6. In the Grading action menu, select Download all submissions.
      7. Expand the zip file.
      8. Edit the two submission files in some way.
      9. Recompress the submissions folder into a zip.
      10. Back in Moodle, in the Grading action menu, select Upload multiple feedback files in a zip.
      11. Upload the new zip and select Import feedback file(s).
      12. Confirm that you see the expected files listed.
      13. Confirm that 2 feedback files are reported as imported or updated.
      14. Click Continue.
      15. Confirm that the proper modified files were attached as Feedback to the submissions.
      16. Check the Download submissions in folders box.
      17. Repeat steps 6-15
      Show
      Create a course with 2 students in it. Add an assignment that has File submissions and Feedback files enabled, and an underscore _ in the assignment name. As each student, make a file submission. As a teacher, navigate to the grading page of the assignment. Make sure that Download submissions in folders is not checked In the Grading action menu, select Download all submissions . Expand the zip file. Edit the two submission files in some way. Recompress the submissions folder into a zip. Back in Moodle, in the Grading action menu, select Upload multiple feedback files in a zip . Upload the new zip and select Import feedback file(s) . Confirm that you see the expected files listed. Confirm that 2 feedback files are reported as imported or updated. Click Continue . Confirm that the proper modified files were attached as Feedback to the submissions. Check the Download submissions in folders box. Repeat steps 6-15
    • Affected Branches:
      MOODLE_38_STABLE, MOODLE_39_STABLE
    • Pull 3.8 Branch:
    • Pull 3.9 Branch:
    • Pull Master Branch:
      MDL-69112-master

      Description

      Basically, if you have an underscore (_) in the root folder name of the zip archive used to upload multiple feedback files, it won't work, and you just get 'No changes' on the next page.

      This will happen pretty easily if you have an _ in your assign name (because the default download zip will have a _ in it's root folder).

      Something like this:

      1. Create a course with a few students
      2. Add an assign that uses file submissions and Feedback files
      3. For at least two students, make a file submission
      4. As the teacher or admin, go and Download All submission from the top dropdown
      5. Open the zip and edit the students files (like marking them up or whatever)
      6. Rezip it
      7. Go to the 'Upload multiple feedback files in a zip'
      8. Upload the new zip and go to the next page
      9. It will show 'No changes'

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              emerrill Eric Merrill
              Reporter:
              emerrill Eric Merrill
              Peer reviewer:
              Peter Dias
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 5 minutes
                  2h 5m