Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69112

Underscore in folder name breaks assign feedback multi-upload

XMLWordPrintable

    • MOODLE_310_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • MOODLE_38_STABLE, MOODLE_39_STABLE
    • MDL-69112-master
    • Hide
      1. Create a course with 2 students in it.
      2. Add an assignment that has File submissions and Feedback files enabled, and an underscore _ in the assignment name.
      3. As each student, make a file submission.
      4. As a teacher, navigate to the grading page of the assignment.
      5. Uncheck the Download submissions in folders checkbox
      6. In the Grading action menu, select Download all submissions.
      7. Expand the zip file.
      8. Edit the two submission files in some way.
      9. Recompress the submissions folder into a zip.
      10. Back in Moodle, in the Grading action menu, select Upload multiple feedback files in a zip.
      11. Upload the new zip and select Import feedback file(s).
      12. Confirm that you see the expected files listed.
      13. Confirm that 2 feedback files are reported as imported or updated.
      14. Click Continue.
      15. Confirm that the proper modified files were attached as Feedback to the submissions.
      16. Check the Download submissions in folders box.
      17. Repeat steps 6-15
      Show
      Create a course with 2 students in it. Add an assignment that has File submissions and Feedback files enabled, and an underscore _ in the assignment name. As each student, make a file submission. As a teacher, navigate to the grading page of the assignment. Uncheck the Download submissions in folders checkbox In the Grading action menu, select Download all submissions . Expand the zip file. Edit the two submission files in some way. Recompress the submissions folder into a zip. Back in Moodle, in the Grading action menu, select Upload multiple feedback files in a zip . Upload the new zip and select Import feedback file(s) . Confirm that you see the expected files listed. Confirm that 2 feedback files are reported as imported or updated. Click Continue . Confirm that the proper modified files were attached as Feedback to the submissions. Check the Download submissions in folders box. Repeat steps 6-15

      Basically, if you have an underscore (_) in the root folder name of the zip archive used to upload multiple feedback files, it won't work, and you just get 'No changes' on the next page.

      This will happen pretty easily if you have an _ in your assign name (because the default download zip will have a _ in it's root folder).

      Something like this:

      1. Create a course with a few students
      2. Add an assign that uses file submissions and Feedback files
      3. For at least two students, make a file submission
      4. As the teacher or admin, go and Download All submission from the top dropdown
      5. Open the zip and edit the students files (like marking them up or whatever)
      6. Rezip it
      7. Go to the 'Upload multiple feedback files in a zip'
      8. Upload the new zip and go to the next page
      9. It will show 'No changes'

        1. MDL-69112.jpg
          MDL-69112.jpg
          33 kB

            emerrill Eric Merrill
            emerrill Eric Merrill
            Peter Dias Peter Dias
            Andrew Lyons Andrew Lyons
            Anna Carissa Sadia Anna Carissa Sadia
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 hours, 50 minutes
                4h 50m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.