Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69113

Assignment grader app saves workflow/marker filters to the wrong preferences

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.7.6, 3.8.3, 3.9
    • Fix Version/s: 3.8.5, 3.9.2
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Create or configure an Assignment activity with marking workflow and marker allocation enabled. Ensure the course has users enrolled as markers (non-editing teacher or teacher) and students.
        1. In the assignment settings go to "Grade" and set "User marking workflow" and "User marking allocation" to yes.
      2. In the Assignment activity, view all submissions, choose a student and press their Grade button. From the Allocated marker list choose a marker, and from the Marking workflow state list choose 'In Marking'. Save changes, then choose the 'View all submissions' link.
      3. On the grading table page, set the basic filter to 'Not submitted', the workflow filter to 'In Marking', and for the marker filter choose the marker allocated to the student.
      4. Choose the 'Grade' button for the student to open the grading app page.
      5. Once the page is fully loaded, open the filters options popup. Observe the filters are set as in step 3.
        1. The filters are directly located underneath the change user dropdown.
      6. Set each filter to a new value except 'No filter', then click 'View all submissions' to return to the grading table.
      7. Observe the filters remain set as they were in step 6.
      8. Confirm behaviour for other combinations of the marking allocation and marking workflow settings as appropriate. i.e. Marking workflow off, Marking workflow on and marker allocation off.
      Show
      Create or configure an Assignment activity with marking workflow and marker allocation enabled. Ensure the course has users enrolled as markers (non-editing teacher or teacher) and students. In the assignment settings go to "Grade" and set "User marking workflow" and "User marking allocation" to yes. In the Assignment activity, view all submissions, choose a student and press their Grade button. From the Allocated marker list choose a marker, and from the Marking workflow state list choose 'In Marking'. Save changes, then choose the 'View all submissions' link. On the grading table page, set the basic filter to 'Not submitted', the workflow filter to 'In Marking', and for the marker filter choose the marker allocated to the student. Choose the 'Grade' button for the student to open the grading app page. Once the page is fully loaded, open the filters options popup. Observe the filters are set as in step 3. The filters are directly located underneath the change user dropdown. Set each filter to a new value except 'No filter', then click 'View all submissions' to return to the grading table. Observe the filters remain set as they were in step 6. Confirm behaviour for other combinations of the marking allocation and marking workflow settings as appropriate. i.e. Marking workflow off, Marking workflow on and marker allocation off.
    • Affected Branches:
      MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • Fixed Branches:
      MOODLE_38_STABLE, MOODLE_39_STABLE
    • Pull from Repository:
    • Pull 3.8 Branch:
    • Pull 3.9 Branch:
    • Pull Master Branch:

      Description

      When using the Assignment grader app for an assignment with both marking allocation and marking workflow enabled, changing the workflow and marker filters causes their values to be interchanged when saved to preferences by AJAX call. (See the attached "wrong preference save.png" the showing request parameters.)

      A consequence of this is that setting workflow and marker filters from the grading table, entering the grader app, and returning to the grading table causes loss of the workflow and marker filter settings.

      The cause: the template defines the form field order as 'filter' -> 'markerfilter' -> 'workflowfilter', while the JavaScript assigns the values to preferences in the order 'assign_filter' -> 'assign_workflowfilter' -> 'assign_markerfilter'.

      The solution: synthesise the preference name from the field name so order becomes unimportant.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jonof Jonathon Fowler
              Reporter:
              jonof Jonathon Fowler
              Peer reviewer:
              Peter Dias
              Integrator:
              Adrian Greeve
              Tester:
              Anna Carissa Sadia
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/Sep/20

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 3 hours, 50 minutes
                  3h 50m