Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69132

Using nonexistent name property in $data structure in restore_stepslib.php

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.9, 4.0
    • Fix Version/s: None
    • Component/s: Backup
    • Affected Branches:
      MOODLE_39_STABLE, MOODLE_40_STABLE

      Description

       Using the latest 3.9 version,  with full error logging, I see a lot of warnings when restoring courses. It seems the courses are restored correctly but the amount of warnings only hides a real problem when that happens.

      The script /backup/moodle2/restore_stepslib.php has several lines that use $data->name, like

      $this->log("restore_process_module   '{$data->name}'  init: $now", backup::LOG_DEBUG); 

      or

      $this->log("restore_grade_item   '{$data->itemname}'  exit: ".(time()-$now), backup::LOG_DEBUG);

      But $data structure processed but those functions has modulename or itemname properties, but not just name. 

      This only seem to affect to logging but I think it should not happen. 

       

       

       

        Attachments

          Activity

            People

            Assignee:
            Unassigned
            Reporter:
            ecastro Enrique Castro
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated: